| apaskulin | |
| Sep 14 2020, 7:24 PM |
| F32350850: Screen Shot 2020-09-11 at 4.20.11 PM.png | |
| Sep 14 2020, 7:24 PM |
| F32350848: Screen Shot 2020-09-11 at 4.14.46 PM.png | |
| Sep 14 2020, 7:24 PM |
To establish consistency with the user menu, replace the search and bell icons in the header with OOUI buttons. The outcome should be uniform behavior and appearance between the three buttons.
Observed behavior:
Icons appear in slightly different sizes:
Hover behavior only present on user button:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Replace bell icon with OOUI button. | mediawiki/skins/WikimediaApiPortal | master | +9 -8 |
Change 634732 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/skins/WikimediaApiPortal@master] Replace bell icon with OOUI button.
The patch replaces the bell icon with an OOUI button, which fixes the hover behavior. The search icon was already an OOUI button, and the hover behavior was OK. This may have been fixed as part of the refactor or another earlier patch. The sizes/spacing may still need tweaking in less.
Change 634732 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] Replace bell icon with OOUI button.
Verified on beta that these three icons are now OOUI buttons. Will track remaining issues separately.