| dmaza | |
| Sep 14 2020, 8:43 PM |
| F32384653: Screen Shot 2020-10-14 at 10.46.31 AM.png | |
| Oct 14 2020, 2:47 PM |
| F32350919: image.png | |
| Sep 14 2020, 8:43 PM |
Steps to reproduce: (using patch demo) https://patchdemo.wmflabs.org/wikis/ecb74701f0e6d1d7712a746b3ba10fc4/w/index.php?title=Test
If you refresh the page it looks fine.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| watchstar: Add temp-watched css class when expiry is present | mediawiki/skins/MinervaNeue | master | +83 -23 |
Change 627371 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/skins/MinervaNeue@master] watchstar: Add temp-watched css class when expiry is present
@Prtksxna @ifried The above patch fixes the half star being left in the wrong angle but there is still a lack of animation when going from a half-star to an empty star.
If watchlist expiry is disabled (you can test in any prod wiki now) the star spins 72deg when transitioning from one state to the other or on page load if you are watching the page. This 72deg rotation is not an option for the half star without having it look incorrectly so my solution was not to spin it when going from half-star to empty or on page-load if the page is temporarily watched.
I'm not sure how else we can handle this, the other option would be to spin it 360deg. Let me know what you think is best.
Hey @Jdlrobson 🙋🏾♂️! We are trying to figure out how the star animation would work with temporary watching. In conversation, @dmaza just pointed out that on mobile, when a page is watched, the star rotates every time the page is refreshed. I wanted to know if this was intentional and what the reason behind this was.
@Prtksxna Can you confirm that the animation transitions we agreed on are the following?
| unwatch -> watch | +72deg |
| watch -> unwatch | -72deg |
| watch -> temp-watch | -72deg |
| temp-watch -> watch | +72deg |
| temp-watch -> unwatch | -72 deg |
I'm still unsure how to handle the last 2.
Change 627371 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] watchstar: Add temp-watched css class when expiry is present
Issue no longer appears on https://en.wikipedia.beta.wmflabs.org MediaWiki 1.36.0-alpha (4453d4a) 2020-10-02T06:23:18.
This change has now been deployed. I tested on the mobile version of frwiki, and the star is half-shaded at the appropriate angle (see screenshot example below). I'm marking this as Done.
