Maniphest T262874

Remove WikiPage::insertProtectNullRevision
Closed, ResolvedPublic
Actions

Description

Hard deprecated, includes a fallback to $wgUser
Also remove the Article::insertProtectNullRevision proxy

No remaining uses (of either) in deployed code: https://codesearch.wmcloud.org/deployed/?q=insertProtectNullRevision%5C(&i=nope&files=&repos=

Details

	Subject	Repo	Branch	Lines +/-
	Remove WikiPage::insertProtectNullRevision	mediawiki/core	master	+3 -115

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T11968 Reduce use of global and public variables
		Open		None	T159283 Deprecate non-configuration globals
		Open		DannyS712	T159299 Deprecate and remove $wgUser
		Resolved		DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
		Open		DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
		Resolved		DannyS712	T245331 Remove core fallbacks to global $wgUser [1.36]
		Resolved		DannyS712	T262874 Remove WikiPage::insertProtectNullRevision

Event Timeline

DannyS712 triaged this task as Medium priority.Sep 14 2020, 11:15 PM

DannyS712 created this task.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.

DannyS712 added a project: Platform Team Workboards (External Code Reviews).

Change 627222 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove WikiPage::insertProtectNullRevision

https://gerrit.wikimedia.org/r/627222

gerritbot added a project: Patch-For-Review.Sep 14 2020, 11:16 PM

Change 627222 merged by jenkins-bot:
[mediawiki/core@master] Remove WikiPage::insertProtectNullRevision

https://gerrit.wikimedia.org/r/627222

DannyS712 closed this task as Resolved.Sep 14 2020, 11:46 PM

DannyS712 removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 15 2020, 12:00 AM