Page MenuHomePhabricator

Autopromote log entry tagged with "VisualEditor"
Open, Needs TriagePublic

Description

This autopromote log entry got tagged with "VisualEditor": https://pl.wikipedia.org/wiki/Specjalna:Rejestr?type=rights&page=User%3ATemuera&subtype=autopromote&uselang=en

Probably the user's last edit was made with the visual editor. The tag isn't relevant here and shouldn't be applied.

(Spotted while working on T237191)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2020, 11:16 PM

We use the 'RecentChange_save' hook for this.

Since MW 1.36, RecentChange objects have an EditResult, which contains some information about the edit that was just saved. Right now the only information is about whether it was a revert, but we might be able to extend that, so that we can fix our code to only tag our edit, instead of whatever else happened in the same request.

Alternatively, we might just check that the RecentChange is not for a log entry…