Page MenuHomePhabricator
Create Task
Maniphest T262877

Find and replace fails to highlight words when opened via F3
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  • open an article for editing in 2017 wikitext editor
  • open find & replace
  • type in some word that shows up multiple times on the screen (scrolling seems to fix highlighting)
  • close find & replace (this and the previous step are needed sometimes but not always)
  • open find & replace with F3

Observe that the word is not highlighted. When you press escape, the word will become selected, so the selection logic works (and F3 advances the selection correctly) but selection is not visible while the find panel is open.
The same does not seem to happen when using Ctrl-F to open the panel.

Seen on Chrome 85 on Ubuntu.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (95f9f5681)mediawiki/extensions/VisualEditormaster+4 -4
FindAndReplace: Always highlight results when openingVisualEditor/VisualEditormaster+6 -6
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Sep 14 2020, 11:39 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptSep 14 2020, 11:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Sep 19 2020, 1:34 PM

Change 628487 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] FindAndReplace: Always highlight results when opening

https://gerrit.wikimedia.org/r/628487

gerritbot added a project: Patch-For-Review.Sep 19 2020, 1:34 PM
Esanders claimed this task.Sep 19 2020, 1:34 PM
Esanders moved this task from To Triage to Triaged on the VisualEditor board.
Esanders added a project: Editing-team (Kanban Board).
Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Sep 21 2020, 5:07 PM

Change 628487 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] FindAndReplace: Always highlight results when opening

https://gerrit.wikimedia.org/r/628487

Maintenance_bot removed a project: Patch-For-Review.Sep 21 2020, 5:10 PM
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 21 2020, 6:06 PM
gerritbot added a comment.Sep 22 2020, 11:26 AM

Change 629091 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (95f9f5681)

https://gerrit.wikimedia.org/r/629091

gerritbot added a project: Patch-For-Review.Sep 22 2020, 11:26 AM
gerritbot added a comment.Sep 22 2020, 8:47 PM

Change 629091 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (95f9f5681)

https://gerrit.wikimedia.org/r/629091

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 22 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 22 2020, 9:10 PM
JTannerWMF added a project: Editing QA.Nov 23 2020, 7:37 PM
JTannerWMF edited projects, added Skipped QA; removed Editing QA.Nov 23 2020, 7:39 PM
JTannerWMF moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
• ppelberg closed this task as Resolved.Nov 25 2020, 6:23 AM
• ppelberg subscribed.

I am marking this as resolved despite not having been able to properly test this. [i]

i. I am using an machine running MacOS, which, as far as I can tell does not use F3 as a shortcut for initiating find and replace. See: https://support.apple.com/en-us/HT207240.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 25 2020, 6:23 AM
Tgr added a comment.EditedNov 25 2020, 7:23 AM

I can confirm that this is now fixed in production. Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL