Page MenuHomePhabricator

Find and replace fails to highlight words when opened via F3
Closed, ResolvedPublic

Description

Steps to reproduce:

  • open an article for editing in 2017 wikitext editor
  • open find & replace
  • type in some word that shows up multiple times on the screen (scrolling seems to fix highlighting)
  • close find & replace (this and the previous step are needed sometimes but not always)
  • open find & replace with F3

Observe that the word is not highlighted. When you press escape, the word will become selected, so the selection logic works (and F3 advances the selection correctly) but selection is not visible while the find panel is open.
The same does not seem to happen when using Ctrl-F to open the panel.

Seen on Chrome 85 on Ubuntu.

Event Timeline

Tgr created this task.Sep 14 2020, 11:39 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptSep 14 2020, 11:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 628487 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] FindAndReplace: Always highlight results when opening

https://gerrit.wikimedia.org/r/628487

Change 628487 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] FindAndReplace: Always highlight results when opening

https://gerrit.wikimedia.org/r/628487

Change 629091 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (95f9f5681)

https://gerrit.wikimedia.org/r/629091

Change 629091 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (95f9f5681)

https://gerrit.wikimedia.org/r/629091

ppelberg closed this task as Resolved.Wed, Nov 25, 6:23 AM
ppelberg added a subscriber: ppelberg.

I am marking this as resolved despite not having been able to properly test this. [i]


i. I am using an machine running MacOS, which, as far as I can tell does not use F3 as a shortcut for initiating find and replace. See: https://support.apple.com/en-us/HT207240.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptWed, Nov 25, 6:23 AM
Tgr added a comment.EditedWed, Nov 25, 7:23 AM

I can confirm that this is now fixed in production. Thanks!