APISite._simple_request conflicts with 'site' parameter of wbeditentity
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	matej_suchanek
	Sep 15 2020, 1:32 PM

Description

site = pywikibot.Site('en', 'wikipedia')
page = pywikibot.Page(site, 'Dummy non-existing page')
item = pywikibot.ItemPage.fromPage(page, lazy_load=True)
item.removeSitelink(page.site, asynchronous=True)

This fails with:
TypeError: create_simple() got multiple values for keyword argument 'site'

It's because the kwargs for APISite._simple_request contain

{
  "site": "enwiki",
  "title": "Dummy"
}

which conflict with the site argument to Request.create_simple call.

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] Fix create_simple in test environment	pywikibot/core	master	+7 -8
	[bugfix] Avoid conflicts between site and possible site keyword	pywikibot/core	master	+5 -3

Customize query in gerrit

Related Objects

Mentioned In: rPWBC265246359b33: [bugfix] Fix create_simple in test environment
rPWBC9dfbe26b2e17: [bugfix] Avoid conflicts between site and possible site keyword

Event Timeline

matej_suchanek created this task.Sep 15 2020, 1:32 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptSep 15 2020, 1:32 PM

matej_suchanek updated the task description. (Show Details)Sep 15 2020, 1:32 PM

Change 637846 had a related patch set uploaded (by Mpaa; owner: Mpaa):
[pywikibot/core@master] [bugfix] Avoid conflicts between site and possible site keyword

https://gerrit.wikimedia.org/r/637846

gerritbot added a project: Patch-For-Review.Oct 31 2020, 8:58 PM

Xqt closed this task as Resolved.Oct 31 2020, 9:21 PM

Xqt assigned this task to Mpaa.

Xqt triaged this task as High priority.

Change 637846 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Avoid conflicts between site and possible site keyword

https://gerrit.wikimedia.org/r/637846

Mpaa mentioned this in rPWBC9dfbe26b2e17: [bugfix] Avoid conflicts between site and possible site keyword.Oct 31 2020, 9:29 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 31 2020, 10:10 PM

Reopened. The patch gives a strange TypeError

Xqt reopened this task as Open.Nov 1 2020, 6:25 AM

Change 637853 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Fix create_simple in test environment

https://gerrit.wikimedia.org/r/637853

gerritbot added a project: Patch-For-Review.Nov 1 2020, 7:34 AM

Change 637853 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Fix create_simple in test environment

https://gerrit.wikimedia.org/r/637853

Xqt mentioned this in rPWBC265246359b33: [bugfix] Fix create_simple in test environment.Nov 1 2020, 10:04 AM

Maintenance_bot removed a project: Patch-For-Review.Nov 1 2020, 10:10 AM

Xqt closed this task as Resolved.Nov 1 2020, 11:02 AM

APISite._simple_request conflicts with 'site' parameter of wbeditentityClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

APISite._simple_request conflicts with 'site' parameter of wbeditentity
Closed, ResolvedPublicBUG REPORT
Actions