Page MenuHomePhabricator
Create Task
Maniphest T262955

Fix PHPUnit deprecation warnings in DonationInterface tests
Closed, ResolvedPublic
Actions

Description

PHPUnit 8 deprecates the expected exception comments and assertArraySubset. Replace these in DonationInterface tests before PHPUnit 9 removes them.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix usages of deprecated PHPUnit methodsmediawiki/extensions/DonationInterfacemaster+33 -34
Fix usages of deprecated PHPUnit methodsmediawiki/extensions/DonationInterfacemaster+33 -34
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ejegg created this task.Sep 15 2020, 5:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2020, 5:31 PM
• DStrine moved this task from Triage to Q3 2021-2022 on the Fundraising-Backlog board.Sep 15 2020, 8:22 PM
Reedy added a parent task: T243600: Migrate MediaWiki core (and thus extensions and skins) to PHPUnit 9.Sep 15 2020, 10:29 PM
gerritbot added a comment.Sep 17 2020, 5:18 AM

Change 627977 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/DonationInterface@master] Fix usages of deprecated PHPUnit methods

https://gerrit.wikimedia.org/r/627977

gerritbot added a project: Patch-For-Review.Sep 17 2020, 5:18 AM
gerritbot added a comment.Oct 17 2020, 10:15 PM

Change 627977 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Fix usages of deprecated PHPUnit methods

https://gerrit.wikimedia.org/r/627977

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Oct 17 2020, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 17 2020, 11:10 PM
gerritbot added a comment.Oct 19 2020, 6:42 PM

Change 635024 had a related patch set uploaded (by Mepps; owner: Ammarpad):
[mediawiki/extensions/DonationInterface@master] Fix usages of deprecated PHPUnit methods

https://gerrit.wikimedia.org/r/635024

gerritbot added a project: Patch-For-Review.Oct 19 2020, 6:42 PM

Change 635024 abandoned by Mepps:
[mediawiki/extensions/DonationInterface@master] Fix usages of deprecated PHPUnit methods

Reason:
A mistake with git review

https://gerrit.wikimedia.org/r/635024

Umherirrender renamed this task from Fix PHPUnit deprecation warnings in DI tests to Fix PHPUnit deprecation warnings in DonationInterface tests.Jan 4 2021, 12:52 AM
Ammarpad closed this task as Resolved.Jan 4 2021, 3:48 AM
Ammarpad claimed this task.
Ammarpad removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits