The flaggedpage_config has a fpc_select field that is unused.
See codesearch: https://codesearch.wmcloud.org/search/?q=fpc_select&i=nope&files=&repos=
Use appears to have been removed by @aaron in 2010 in c6cb71ae089c118ecd024059186c0fcfa75c0762
Can the column be removed?
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T31744 FlaggedRev installation (deployment) requests (tracking) | |||
| Stalled | None | T143886 Activating Flagged revisions on ar.wikinews | |||
| Stalled | None | T204354 Flagged Revisions for Vietnamese Wikipedia | |||
| Stalled | None | T205145 Deploy FlaggedRevs on bn.wikibooks | |||
| Stalled | None | T221933 Enable Flagged Revisions (for trial run purpose) at the Chinese Wikipedia | |||
| Open | None | T185664 Code stewardship review: FlaggedRevs | |||
| Resolved | • Ladsgroup | T277883 Drop all low-use and unused features of FlaggedRevs to make it more maintainable | |||
| Resolved | Zabe | T262978 flaggedpage_config.fpc_select is unused | |||
| Resolved | • Ladsgroup | T306147 Make flaggedpage_config.fpc_select nullable on wmf wikis | |||
| Resolved | • Ladsgroup | T308933 Drop flaggedpage_config.fpc_select column on wmf wikis |
Removing the DBA tag until it is decided whether it can be or cannot be removed.
Once it is clear, let's use the Schema-change-in-production tag and the template for it at: https://wikitech.wikimedia.org/wiki/Schema_changes#Workflow_of_a_schema_change
Thanks!
It's not meaningfully used, though it is NON NULL so the code still references it during insertion (using -1).
Is it okay to remove?
I also am not familiar with how replace works - does it need to specify a value as long as the column exists?
Change 779566 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/FlaggedRevs@master] Make flaggedpage_config.fpc_select nullable
Change 779566 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Make flaggedpage_config.fpc_select nullable
Made nullable now, so we can stop writing to it (after DBA made it nullable in production) and then we can eventually remove the column.
Change 783869 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/FlaggedRevs@master] Stop writing -1 to unused flaggedpage_config.fpc_select
Change 783869 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Stop writing -1 to unused flaggedpage_config.fpc_select
Change 790708 had a related patch set uploaded (by Zabe; author: Zabe):
[operations/puppet@production] filtered_tables: remove flaggedpage_config.fpc_select
Change 793910 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/FlaggedRevs@master] Drop flaggedpage_config.fpc_select column
Change 793910 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Drop flaggedpage_config.fpc_select column
Change 790708 merged by Ladsgroup:
[operations/puppet@production] filtered_tables: remove flaggedpage_config.fpc_select