Page MenuHomePhabricator

flaggedpage_config.fpc_select is unused
Closed, ResolvedPublic

Description

The flaggedpage_config has a fpc_select field that is unused.

See codesearch: https://codesearch.wmcloud.org/search/?q=fpc_select&i=nope&files=&repos=

Use appears to have been removed by @aaron in 2010 in c6cb71ae089c118ecd024059186c0fcfa75c0762

Can the column be removed?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Marostegui added a subscriber: Marostegui.

Removing the DBA tag until it is decided whether it can be or cannot be removed.
Once it is clear, let's use the Blocked-on-schema-change tag and the template for it at: https://wikitech.wikimedia.org/wiki/Schema_changes#Workflow_of_a_schema_change

Thanks!

It's not meaningfully used, though it is NON NULL so the code still references it during insertion (using -1).

It's not meaningfully used, though it is NON NULL so the code still references it during insertion (using -1).

Is it okay to remove?
I also am not familiar with how replace works - does it need to specify a value as long as the column exists?

Change 779566 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/FlaggedRevs@master] Make flaggedpage_config.fpc_select nullable

https://gerrit.wikimedia.org/r/779566

Change 779566 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Make flaggedpage_config.fpc_select nullable

https://gerrit.wikimedia.org/r/779566

It's not meaningfully used, though it is NON NULL so the code still references it during insertion (using -1).

Made nullable now, so we can stop writing to it (after DBA made it nullable in production) and then we can eventually remove the column.

Change 783869 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/FlaggedRevs@master] Stop writing -1 to unused flaggedpage_config.fpc_select

https://gerrit.wikimedia.org/r/783869

Change 783869 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Stop writing -1 to unused flaggedpage_config.fpc_select

https://gerrit.wikimedia.org/r/783869

Change 790708 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/puppet@production] filtered_tables: remove flaggedpage_config.fpc_select

https://gerrit.wikimedia.org/r/790708

Change 793910 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/FlaggedRevs@master] Drop flaggedpage_config.fpc_select column

https://gerrit.wikimedia.org/r/793910

Change 793910 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Drop flaggedpage_config.fpc_select column

https://gerrit.wikimedia.org/r/793910

Change 790708 merged by Ladsgroup:

[operations/puppet@production] filtered_tables: remove flaggedpage_config.fpc_select

https://gerrit.wikimedia.org/r/790708