Page MenuHomePhabricator

Follow refs aren't getting unique ids
Closed, ResolvedPublic

Description

From the test added in,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/627392/4/tests/parser/citeParserTests.txt

SUB<sup about="#mwt4" class="mw-ref" id="cite_ref-theName_1-1" rel="dc:references" typeof="mw:Extension/ref" data-mw='{"name":"ref","attrs":{"name":"theName"},"body":{"html":""}}'><a href="./Parser_test#cite_note-theName-1" style="counter-reset: mw-Ref 1;"><span class="mw-reflink-text">[1]</span></a></sup>
MUL<sup about="#mwt6" class="mw-ref" id="cite_ref-theName_1-1" rel="dc:references" typeof="mw:Extension/ref" style="display: none;" data-mw='{"name":"ref","attrs":{"follow":"theName"},"body":{"id":"mw-reference-text-cite_note-theName-1"}}'><a href="./Parser_test#cite_note-theName-1" style="counter-reset: mw-Ref 1;"><span class="mw-reflink-text">[1]</span></a></sup>

Both have id="cite_ref-theName_1-1"

Event Timeline

Arlolra created this task.Tue, Sep 15, 10:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Sep 15, 10:41 PM
Arlolra triaged this task as High priority.Tue, Sep 15, 10:42 PM

Change 627891 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] WIP adding extra key component to follow id's to avoid duplication

https://gerrit.wikimedia.org/r/627891

Change 627891 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Removed parsoid cite extension follow ref id's

https://gerrit.wikimedia.org/r/627891

Arlolra closed this task as Resolved.Thu, Sep 17, 5:44 PM

Change 628944 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a10

https://gerrit.wikimedia.org/r/628944

Change 628944 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a10

https://gerrit.wikimedia.org/r/628944