Maniphest T263058

Memory leak in node-apn
Open, LowPublicBUG REPORT
Actions

Assigned To

None

Authored By

	• Mholloway
	Sep 16 2020, 8:33 PM

Tags

Referenced Files

None

Subscribers

Description

This report corresponds to upstream issue https://github.com/node-apn/node-apn/issues/674. There is a memory leak in node-apn (or one of its dependencies).

Steps to Reproduce: Start the service, send a message to APNS through it, and then leave it running for a while (~15 mins).

Results: The following warning is emitted:

(node:74264) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 wakeup listeners added. Use emitter.setMaxListeners() to increase limit

Observed locally while running with node v10.15.3 on Ubuntu 20.04, and also on the Beta Cluster while running in image 2020-09-16-184730-publish.

Related Objects

Mentioned In: T265258: High latency on push notification service initialization

Event Timeline

• Mholloway created this task.Sep 16 2020, 8:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2020, 8:33 PM

• Mholloway updated the task description. (Show Details)Sep 16 2020, 8:38 PM

• Mholloway updated the task description. (Show Details)Sep 16 2020, 8:42 PM

• Mholloway updated the task description. (Show Details)Sep 16 2020, 9:31 PM

• Mholloway updated the task description. (Show Details)Sep 16 2020, 9:51 PM

• Mholloway updated the task description. (Show Details)

One of the suggestions as a workaround for that issue that doesn't rely in an upstream fix could be :

Batch notifications (as we already do)
Create an APN client instance on queue flush
Destroy after notifications are send

Maybe its worth trying that locally and see if it resolves the memory leak

LGoto triaged this task as Low priority.Sep 23 2020, 3:40 PM

LGoto moved this task from Needs triage to Backlog on the Product-Infrastructure-Team-Backlog-Deprecated board.

MSantos mentioned this in T265258: High latency on push notification service initialization.Nov 3 2020, 1:06 PM