Page MenuHomePhabricator
Create Task
Maniphest T263061

"Advanced" option stays open unless you close it from both Reply modes
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Open the Reply tool.
  2. Open the Advanced option.
  3. Switch to the other Reply mode (for example: Source mode).
  4. Click on "Cancel" to close the Reply tool.
  5. Open the Reply tool again.

Observe that the Advanced option is still open inside the Reply tool source mode. I think it should not.

Now do the following:

  1. Close the Advanced option.
  2. Close the Reply tool.
  3. Open the Reply tool again.

Observe that, the Advanced option is still open even though you closed it in your previous session.

Now do the following:

  1. Close the Advanced option.
  2. Switch to the other Reply mode.
  3. Now close the Reply tool.
  4. Open the Reply tool.

Observed that, this time the "Advanced" option has remained closed.

Browser: Chrome

Wiki: English

Environment: Beta cluster

Page: https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:RYasmeen_(WMF)/sandbox

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ReplyWidget: Pass initial config values to #setup, not to constructormediawiki/extensions/DiscussionToolsmaster+39 -28
Collapse advanced drawer when clearingmediawiki/extensions/DiscussionToolsmaster+13 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ryasmeen created this task.Sep 16 2020, 9:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2020, 9:12 PM
Ryasmeen mentioned this in T263062: Inconsistencies around the highlight of the default comment summary.Sep 16 2020, 9:17 PM
Ryasmeen added a parent task: T249391: Add support for customizing edit summaries for comments posted using Reply tool.Sep 21 2020, 7:05 PM
gerritbot added a comment.Sep 21 2020, 7:53 PM

Change 628926 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Collapse advanced drawer when clearing

https://gerrit.wikimedia.org/r/628926

gerritbot added a project: Patch-For-Review.Sep 21 2020, 7:53 PM
Esanders added a project: Editing-team (Kanban Board).Sep 21 2020, 7:53 PM
Esanders moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Sep 21 2020, 9:08 PM

Change 628926 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Collapse advanced drawer when clearing

https://gerrit.wikimedia.org/r/628926

Maintenance_bot removed a project: Patch-For-Review.Sep 21 2020, 9:10 PM
Esanders mentioned this in rEDTOe6b91ced43c3: Collapse advanced drawer when clearing.Sep 21 2020, 9:35 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 21 2020, 10:01 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 21 2020, 10:52 PM
matmarex added a project: Editing QA.
matmarex subscribed.
ppelberg mentioned this in T249394: Deploy Reply Tool as opt-out Preference at the Arabic, Czech and Hungarian Wikipedias.Sep 23 2020, 6:12 PM
Ryasmeen added a subscriber: Esanders.Sep 24 2020, 8:36 PM

@matmarex/@Esanders: I checked this on Patch Demo, this seems to be not fixed.

Ryasmeen moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Sep 24 2020, 8:36 PM
Ryasmeen mentioned this in T249391: Add support for customizing edit summaries for comments posted using Reply tool.Sep 24 2020, 8:41 PM
matmarex claimed this task.Sep 25 2020, 5:02 PM
matmarex moved this task from Blocked / Needs More Work to Code Review on the Editing-team (Kanban Board) board.Sep 25 2020, 5:21 PM
gerritbot added a comment.Sep 25 2020, 5:21 PM

Change 630217 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Pass initial config values to #setup, not to constructor

https://gerrit.wikimedia.org/r/630217

gerritbot added a project: Patch-For-Review.Sep 25 2020, 5:21 PM
gerritbot added a comment.Sep 25 2020, 9:51 PM

Change 630217 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Pass initial config values to #setup, not to constructor

https://gerrit.wikimedia.org/r/630217

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.11; 2020-09-29); removed MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 25 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 25 2020, 10:10 PM
Esanders moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 27 2020, 2:07 PM
matmarex added a comment.Sep 27 2020, 6:58 PM

@Ryasmeen Thanks for spotting this, it should be really fixed now.

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 28 2020, 8:21 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Sep 28 2020, 8:33 PM
ppelberg added a comment.Oct 1 2020, 1:33 AM
In T263061#6496858, @matmarex wrote:

@Ryasmeen Thanks for spotting this, it should be really fixed now.

This works as is described in the task; however, @Esanders, will it conflict with what we are planning to implement in T261539?

matmarex added a comment.Oct 1 2020, 4:44 PM

No, I don't see why it would conflict.

ppelberg closed this task as Resolved.Oct 1 2020, 6:16 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 1 2020, 6:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits