Page MenuHomePhabricator

CoreParserFunctionsTest::testGender doesn't use $msg2
Closed, ResolvedPublic

Description

5fd1e1abe0ef9e7c810a9c72fbb9104461c4e331 added CoreParserFunctionsTest::testGender

		$msg = ( new RawMessage( '{{GENDER:*Female|m|f|o}}' ) )->parse();
		$this->assertEquals( $msg, 'f', 'Works unescaped' );
		$escapedName = wfEscapeWikiText( '*Female' );
		$msg2 = ( new RawMessage( '{{GENDER:' . $escapedName . '|m|f|o}}' ) )
			->parse();
		$this->assertEquals( $msg, 'f', 'Works escaped' );

Shouldn't the second assertEquals be using $msg2? Otherwise, what is the point of it...

Event Timeline

Change 627945 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Use $msg2 in CoreParserFunctionsTest::testGender

https://gerrit.wikimedia.org/r/627945

Change 627945 merged by jenkins-bot:
[mediawiki/core@master] Use $msg2 in CoreParserFunctionsTest::testGender

https://gerrit.wikimedia.org/r/627945

Reedy claimed this task.

Probably not worth backporting