Page MenuHomePhabricator
Create Task
Maniphest T263188

Create sniff to find combination of final and private modifier on php functions - deprecated with php8
Closed, ResolvedPublic
Actions

Description

The combination of final + private gets deprecated and could be autofixed by a sniff.

https://wiki.php.net/rfc/inheritance_private_methods

Warning: Private methods cannot be final as they are never overridden by other classes

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Release v34.0.0Jforrestermediawiki/tools/codesniffermaster+57 -2
Add FinalPrivateSniffDannyS712mediawiki/tools/codesniffermaster+135 -0
Customize query in gerrit

Event Timeline

Umherirrender created this task.Sep 17 2020, 8:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2020, 8:13 PM
DannyS712 claimed this task.Sep 17 2020, 8:16 PM
DannyS712 moved this task from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.
Restricted Application added a project: User-DannyS712. · View Herald TranscriptSep 17 2020, 8:16 PM
gerritbot added a comment.Sep 17 2020, 8:17 PM

Change 628209 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/tools/codesniffer@master] Add FinalPrivateSniff

https://gerrit.wikimedia.org/r/628209

gerritbot added a project: Patch-For-Review.Sep 17 2020, 8:17 PM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Sep 17 2020, 8:47 PM
gerritbot added a comment.Oct 30 2020, 5:24 PM

Change 628209 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Add FinalPrivateSniff

https://gerrit.wikimedia.org/r/628209

DannyS712 closed this task as Resolved.Oct 30 2020, 5:26 PM
DannyS712 removed a project: Patch-For-Review.
gerritbot added a comment.Dec 5 2020, 2:35 AM

Change 645471 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/tools/codesniffer@master] Release v34.0.0

https://gerrit.wikimedia.org/r/645471

gerritbot added a project: Patch-For-Review.Dec 5 2020, 2:35 AM
gerritbot added a comment.Dec 5 2020, 7:15 AM

Change 645471 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Release v34.0.0

https://gerrit.wikimedia.org/r/645471

Maintenance_bot removed a project: Patch-For-Review.Dec 5 2020, 8:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits