Page MenuHomePhabricator

Create sniff to find combination of final and private modifier on php functions - deprecated with php8
Closed, ResolvedPublic

Description

The combination of final + private gets deprecated and could be autofixed by a sniff.

https://wiki.php.net/rfc/inheritance_private_methods

Warning: Private methods cannot be final as they are never overridden by other classes

Event Timeline

Change 628209 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/tools/codesniffer@master] Add FinalPrivateSniff

https://gerrit.wikimedia.org/r/628209

Change 628209 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Add FinalPrivateSniff

https://gerrit.wikimedia.org/r/628209

Change 645471 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/tools/codesniffer@master] Release v34.0.0

https://gerrit.wikimedia.org/r/645471

Change 645471 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Release v34.0.0

https://gerrit.wikimedia.org/r/645471