Page MenuHomePhabricator

Change key names in WikibaseManifest from camelCase to snake_case
Closed, ResolvedPublic

Description

According to the WMF Core Platform Team's REST API Design principles, inherited by the the Wikibase REST API proposal, multi-word properties in json repsonses should be written in Snake-case, i.e. this_property not thisProperty.

The following key names from the WikibaseManifest prototype must therefore be changed.

In ManifestGenerator.php:

  • rootScriptUrl --> root_script_url
  • equivEntities --> equiv_entities
  • localRdfNamespaces --> local_rdf_namespaces
  • externalServices --> external_services
  • entities --> entity_sources (according to T262807)

In EntityNamespaces.php:

  • namespaceId --> namespace_id
  • namespaceString --> namespace_string

In ExternalServices.php:

  • queryservice_ui --> queryservice_ui
  • openrefine-reconcile --> openrefine_reconcile

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 628324 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/WikibaseManifest@master] Change key names from camelCase to snake_case

https://gerrit.wikimedia.org/r/628324

Change 628324 merged by jenkins-bot:
[mediawiki/extensions/WikibaseManifest@master] Change key names from camelCase to snake_case

https://gerrit.wikimedia.org/r/628324

gerritbot missed to remove the "Patch-For-Review" tag after https://gerrit.wikimedia.org/r/628324 got merged