Page MenuHomePhabricator
Create Task
Maniphest T263334

Do not call SpecialBlock::canBlockEmail from CheckUser
Closed, ResolvedPublic
Actions

Description

SpecialBlock::canBlockEmail was deprecated in 3c2c7b0f3982f533cc9eee4960950eb8f925b448 and is called from CheckUser.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Do not call SpecialBlock::canBlockEmail from CheckUserUrbanecmmediawiki/extensions/CheckUsermaster+31 -5
Replace usages of SpecialBlock::canBlockEmail for MW 1.36+Urbanecmmediawiki/extensions/CheckUsermaster+91 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm created this task.Sep 19 2020, 5:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2020, 5:55 PM
gerritbot added a comment.Sep 19 2020, 6:16 PM

Change 628506 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/CheckUser@master] Do not call SpecialBlock::canBlockEmail from CheckUser

https://gerrit.wikimedia.org/r/628506

gerritbot added a project: Patch-For-Review.Sep 19 2020, 6:16 PM
Urbanecm claimed this task.Sep 19 2020, 6:16 PM
Urbanecm triaged this task as Low priority.
Urbanecm added a project: Technical-Debt.
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptSep 19 2020, 6:16 PM
Maintenance_bot moved this task from Backlog to Waiting on review on the User-Urbanecm board.Sep 19 2020, 6:24 PM
gerritbot added a comment.Sep 19 2020, 7:51 PM

Change 628506 abandoned by Urbanecm:
[mediawiki/extensions/CheckUser@master] Do not call SpecialBlock::canBlockEmail from CheckUser

Reason:
ignoring this for now

https://gerrit.wikimedia.org/r/628506

Urbanecm removed Urbanecm as the assignee of this task.Sep 19 2020, 7:51 PM
Urbanecm moved this task from Waiting on review to Later on the User-Urbanecm board.
gerritbot added a comment.Oct 9 2020, 6:52 PM

Change 633221 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/CheckUser@master] Replace usages of SpecialBlock::canBlockEmail

https://gerrit.wikimedia.org/r/633221

Urbanecm claimed this task.Oct 9 2020, 6:52 PM
Urbanecm moved this task from Later to Waiting on review on the User-Urbanecm board.
gerritbot added a comment.Oct 14 2020, 7:41 PM

Change 628506 restored by Urbanecm:
[mediawiki/extensions/CheckUser@master] Do not call SpecialBlock::canBlockEmail from CheckUser

https://gerrit.wikimedia.org/r/628506

gerritbot added a comment.Oct 14 2020, 7:42 PM

Change 633221 abandoned by Urbanecm:
[mediawiki/extensions/CheckUser@master] Replace usages of SpecialBlock::canBlockEmail for MW 1.36+

Reason:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/ /632906 bumped MW support, so this isn't needed now

https://gerrit.wikimedia.org/r/633221

Urbanecm mentioned this in T265552: Use of SpecialBlock::canBlockEmail was deprecated in MediaWiki 1.36. [Called from SpecialCheckUser::getBlockForm].Oct 21 2020, 7:15 AM
gerritbot added a comment.Oct 26 2020, 12:26 AM

Change 628506 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Do not call SpecialBlock::canBlockEmail from CheckUser

https://gerrit.wikimedia.org/r/628506

Urbanecm closed this task as Resolved.Oct 26 2020, 12:27 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 26 2020, 1:00 AM
Urbanecm reopened this task as Open.Oct 26 2020, 1:29 AM
Urbanecm closed this task as Resolved.Oct 26 2020, 1:42 AM
Urbanecm removed a project: Patch-For-Review.
thiemowmde merged a task: T266179: Use of SpecialBlock::canBlockEmail was deprecated in MediaWiki 1.36. [Called from SpecialCheckUser::getBlockForm].Oct 27 2020, 5:35 PM
thiemowmde added a subscriber: • Clarakosi.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits