Make Beta Codesearch tool the default
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ammarpad
	Sep 20 2020, 2:05 PM

Description

People still share the old link and every time I have to edit the url to change to the better site, because it's vastly more user-friendly and nice-looking. Please make https://codesearch-beta.wmcloud.org/ the default and redirect all the old links.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
frontend: Rewrite codesearch-beta, make feature-complete, fix bugs	labs/codesearch	master	+2 K -1 K
frontend: Remove "β" marker from doc titles	labs/codesearch	master	+3 -3
frontend: Add /api/ compat redirect	labs/codesearch	master	+4 -2
wmf-config-wg-vars: Switch API query to codesearch-backend	mediawiki/tools/code-utils	master	+1 -1
[WIP] frontend: Rewrite codesearch-beta, make feature-complete, fix bugs	labs/codesearch	master	+1 K -993

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krinkle	T263354 Make Beta Codesearch tool the default
		Resolved		Krinkle	T320909 codesearch beta doesn't have line separators between file chunks

Event Timeline

Ammarpad created this task.Sep 20 2020, 2:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2020, 2:05 PM

Ammarpad added a project: VPS-project-Codesearch.Sep 20 2020, 2:05 PM

Ammarpad added a subscriber: Legoktm.

Ladsgroup awarded a token.Sep 20 2020, 2:09 PM

Kizule awarded a token.Sep 20 2020, 2:44 PM

I'm not really sure what the future of codesearch is with the whole GitLab discussion so I've mostly been holding off investing time into it until it's clearer.

On a technical level, the main TODOs are:

Get the performance on par with the current frontend. If it's not possible to do in the Rust/wasm codebase we have right now, we should just render the results server-side.
Integrate the beta frontend into the proxy, which would be a good excuse to rewrite the proxy in Rust
Ask for another round of testing before switching over

Change 804789 had a related patch set uploaded (by Krinkle; author: Krinkle):

[labs/codesearch@master] [WIP] frontend: Rewrite codesearch-beta, make feature-complete, fix bugs

https://gerrit.wikimedia.org/r/804789

Change 804785 had a related patch set uploaded (by Krinkle; author: Krinkle):

[labs/codesearch@master] frontend: Rewrite codesearch-beta, make feature-complete, fix bugs

https://gerrit.wikimedia.org/r/804785

Change 804789 abandoned by Krinkle:

[labs/codesearch@master] [WIP] frontend: Rewrite codesearch-beta, make feature-complete, fix bugs

Reason:

https://gerrit.wikimedia.org/r/804789

Change 804785 merged by jenkins-bot:

[labs/codesearch@master] frontend: Rewrite codesearch-beta, make feature-complete, fix bugs

https://gerrit.wikimedia.org/r/804785

Maintenance_bot removed a project: Patch-For-Review.Oct 8 2022, 2:30 AM

Krinkle mentioned this in T290819: Codesearch main page redirect uses http instead of https.Oct 8 2022, 3:54 AM

Daimona awarded a token.Oct 8 2022, 11:21 AM

Daimona subscribed.

The beta feels far more user-friendly than the old version, and is already being referenced.

At a glance, these are the only beta-related tasks:

The fourth is not a regression (the current version does not preserve anything when switching). Are any of the first three considered blockers?

In T263354#6511248, @Legoktm wrote:

I'm not really sure what the future of codesearch is with the whole GitLab discussion so I've mostly been holding off investing time into it until it's clearer.

FWIW, I don't think gitlab would fully replace codesearch. We still need to search in third party codes for deprecation and such.

@Krinkle at SAL entry:

Create new https://codesearch-backend.wmcloud.org/ webproxy, points to the same location as codesearch-old.

@Krinkle on Gerrit patch:

frontend: Switch to codesearch-backend.wmcloud.org hostname

Krinkle mentioned this in T321345: Codesearch Beta: repo list is truncated in dropdown.Mar 12 2023, 11:23 PM

Krinkle added a subtask: T320909: codesearch beta doesn't have line separators between file chunks.Mar 13 2023, 12:19 AM

Change 897393 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/tools/code-utils@master] wmf-config-wg-vars: Switch API query to codesearch-backend

https://gerrit.wikimedia.org/r/897393

gerritbot added a project: Patch-For-Review.Mar 13 2023, 12:32 AM

Change 897393 merged by jenkins-bot:

[mediawiki/tools/code-utils@master] wmf-config-wg-vars: Switch API query to codesearch-backend

https://gerrit.wikimedia.org/r/897393

Change 897394 had a related patch set uploaded (by Krinkle; author: Krinkle):

[labs/codesearch@master] frontend: Add /api/ compat redirect

https://gerrit.wikimedia.org/r/897394

Krinkle closed subtask T320909: codesearch beta doesn't have line separators between file chunks as Resolved.Mar 13 2023, 12:46 AM

Change 897394 merged by jenkins-bot:

[labs/codesearch@master] frontend: Add /api/ compat redirect

https://gerrit.wikimedia.org/r/897394

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2023, 1:10 AM

Mentioned in SAL (#wikimedia-cloud) [2023-03-13T01:12:44Z] <Krinkle> Change codesearch.wmcloud.org proxy from port 3002 (Hound UI) to 3003 (new Codesearch frontend), ref T263354

Krinkle closed this task as Resolved.Mar 13 2023, 1:13 AM

Krinkle claimed this task.

Krinkle triaged this task as Medium priority.

Change 898060 had a related patch set uploaded (by Krinkle; author: Krinkle):

[labs/codesearch@master] frontend: Remove "β" marker from doc titles

https://gerrit.wikimedia.org/r/898060

gerritbot added a project: Patch-For-Review.Mar 13 2023, 11:49 PM

Change 898060 merged by jenkins-bot:

[labs/codesearch@master] frontend: Remove "β" marker from doc titles

https://gerrit.wikimedia.org/r/898060

Maintenance_bot removed a project: Patch-For-Review.Mar 14 2023, 5:10 AM

Lucas_Werkmeister_WMDE mentioned this in T332054: Codesearch frontend still says β in title after promotion to codesearch.wmcloud.org.Mar 14 2023, 4:36 PM