Page MenuHomePhabricator
Create Task
Maniphest T263409

Display pending element and error message on the IPInfo popup, where appropriate
Closed, ResolvedPublic2 Estimated Story PointsOct 6 2020
Actions

Description

After T263407: Create Widget for displaying data asynchronously, display an error if the API returns an error or malformed data.

Details

Due Date
Oct 6 2020, 4:00 AM
SubjectRepoBranchLines +/-
Display error returned from API in IPInfo widgetmediawiki/extensions/IPInfomaster+50 -18
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Sep 21 2020, 8:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2020, 8:39 AM
Tchanders added a subtask: T263407: Create Widget for displaying data asynchronously.Sep 21 2020, 8:39 AM
Tchanders mentioned this in T260604: Display a popup with fixed mock data for an IP address on the specified page(s).Sep 21 2020, 9:51 AM
Tchanders mentioned this in T263442: Display API failure errors in the IPInfo popup.Sep 21 2020, 11:51 AM
Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Sep 22 2020, 12:06 AM
Niharika triaged this task as Medium priority.Sep 23 2020, 5:24 AM
Niharika moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.Sep 23 2020, 4:50 PM
Niharika set the point value for this task to 2.
ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Sep 23 2020, 4:54 PM
ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
ARamirez_WMF set Due Date to Oct 6 2020, 4:00 AM.Sep 30 2020, 4:08 PM
ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".
Tchanders claimed this task.Oct 5 2020, 3:34 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
Tchanders updated the task description. (Show Details)Oct 6 2020, 1:38 PM
Tchanders updated the task description. (Show Details)
Tchanders added a subscriber: • Prtksxna.EditedOct 6 2020, 3:20 PM

@Prtksxna How do you think the error looks, with the MessageWidget (type: error) styling?

image.png (156×418 px, 15 KB)

Same thing, with inline: true:

image.png (137×415 px, 17 KB)

Tchanders mentioned this in T263407: Create Widget for displaying data asynchronously.Oct 6 2020, 3:21 PM
gerritbot added a comment.Oct 6 2020, 3:36 PM

Change 632507 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/IPInfo@master] WIP Display error returned from API in IPInfo widget

https://gerrit.wikimedia.org/r/632507

gerritbot added a project: Patch-For-Review.Oct 6 2020, 3:36 PM
Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Oct 6 2020, 4:57 PM
Tchanders added a comment.Oct 6 2020, 5:18 PM

Note that the error messages will be displayed in the content language (or fallback languages if that isn't available), rather than the user language, until T264777.

Tchanders added a comment.Oct 6 2020, 6:59 PM
In T263409#6521873, @Tchanders wrote:

@Prtksxna How do you think the error looks, with the MessageWidget (type: error) styling?

image.png (156×418 px, 15 KB)

Same thing, with inline: true:

image.png (137×415 px, 17 KB)

Summary from a meeting: @Prtksxna agreed to go with the inline option

gerritbot added a comment.Oct 7 2020, 6:23 PM

Change 632507 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Display error returned from API in IPInfo widget

https://gerrit.wikimedia.org/r/632507

dbarratt moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Oct 7 2020, 6:26 PM
Tchanders mentioned this in rEIPIc2b9eeec8e13: Display error returned from API in IPInfo widget.Oct 7 2020, 6:34 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 7 2020, 7:10 PM
Niharika closed subtask T263407: Create Widget for displaying data asynchronously as Resolved.Oct 13 2020, 11:51 PM
dom_walden moved this task from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.Oct 15 2020, 1:35 PM
dom_walden subscribed.

We now display the error message returned by the API, for example:

error_suppressed.png (146×354 px, 14 KB)

If there is some other problem (e.g. the connection to the API is blocked), it returns a generic error message:

error_generic.png (108×333 px, 11 KB)

Niharika closed this task as Resolved.Oct 19 2020, 9:56 PM
Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 8:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL