Page MenuHomePhabricator

Display pending element and error message on the IPInfo popup, where appropriate
Closed, ResolvedPublic2 Estimated Story PointsOct 6 2020

Description

After T263407: Create Widget for displaying data asynchronously, display an error if the API returns an error or malformed data.

Details

Event Timeline

Niharika triaged this task as Medium priority.Sep 23 2020, 5:24 AM
ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".
Tchanders updated the task description. (Show Details)

@Prtksxna How do you think the error looks, with the MessageWidget (type: error) styling?

image.png (156×418 px, 15 KB)

Same thing, with inline: true:

image.png (137×415 px, 17 KB)

Change 632507 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/IPInfo@master] WIP Display error returned from API in IPInfo widget

https://gerrit.wikimedia.org/r/632507

Note that the error messages will be displayed in the content language (or fallback languages if that isn't available), rather than the user language, until T264777.

@Prtksxna How do you think the error looks, with the MessageWidget (type: error) styling?

image.png (156×418 px, 15 KB)

Same thing, with inline: true:

image.png (137×415 px, 17 KB)

Summary from a meeting: @Prtksxna agreed to go with the inline option

Change 632507 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Display error returned from API in IPInfo widget

https://gerrit.wikimedia.org/r/632507

dom_walden added a subscriber: dom_walden.

We now display the error message returned by the API, for example:

error_suppressed.png (146×354 px, 14 KB)

If there is some other problem (e.g. the connection to the API is blocked), it returns a generic error message:

error_generic.png (108×333 px, 11 KB)