How is this related to T263410: Test instance: Update CodeMirror color scheme? I see the tasks were written on the same day, so probably not duplicates, but am I reading correctly that this is a task to add preferences, and the preferences control the implementation done in the other task?

The tasks are not dependent on each other and can be implemented separately and in any sequence (unless there is a tech dependency I'm unaware of).

T263410: Test instance: Update CodeMirror color scheme is to update the existing color scheme of the CodeMirror extension (to be applied to the syntax highlighting function). It does not depend on a preference, it should be used by default when the syntax highlighter pen is enabled in the editor.

The current ticket is to add an accessible color scheme to CodeMirror/syntax highlighting and a preference to enable it. So it's a two step process: 1) add preference to enable accessible syntax highlighting, and 2) add a secondary color scheme to CodeMirror to be used by the syntax highlighter when the preference is turned on (or the other way around, whatever makes more sense). Whether this secondary color scheme then replaces the current color scheme used by CodeMirror or the one specified in T263410: Test instance: Update CodeMirror color scheme should not be relevant for this ticket.

Does that makes sense or have I missed/misunderstood something?

I made a mockup of the described feature. Would that be the correct position for the setting? @ECohen_WMDE

Hey @lilients_WMDE - re Thiemo and Adam's comments, let's move it to the Editing tab, after the Editor preferences. The second image would look the same (section, checkbox, content) but simply moved to be part of the other settings. Thanks!

Ok, so it would look like this:

Looks great!

It lookes like this now:

New option in editing settings:

Colorblind-friendly syntax highlighting:

Looks like the accessibility typo is still there in your screenshot, though when I check on the test instance it's looking alright

Right! I have to update the screenshots as well. :)

Notes from demo time:

• The accessibility color scheme doesn't show up in the VE source mode (a.k.a. "new wikitext mode").