Page MenuHomePhabricator

Gap caused by floated image after a reference has been changed
Closed, ResolvedPublic

Description

Presumably caused by a clear CSS property being set somewhere in the reference list:

Steps

  1. Open https://en.wikipedia.org/wiki/Aston_Martin_Bulldog?veaction=edit at ~1200px wide
  2. Edit/delete/move a reference to cause the reflist to update
  3. Observe the big gap in the list

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2020, 11:56 AM

The cause is the clearfix on .mw-body-content. I think we should disable that by default for preview elements. If a specific preview element needs a clearfix it can add it back in.

Change 628784 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Turn off clearfix on MWPreviewElement

https://gerrit.wikimedia.org/r/628784

Change 628789 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/Vector@master] Follow-up I673c28c2: Only apply clearfix to main content area

https://gerrit.wikimedia.org/r/628789

Change 628784 abandoned by Esanders:
[mediawiki/extensions/VisualEditor@master] Turn off clearfix on MWPreviewElement

Reason:
Fixed upstream in Vector instead: I693cd3d4d32501a2a4ab20140a662943fba22bb6

https://gerrit.wikimedia.org/r/628784

Change 628789 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Follow-up I673c28c2: Only apply clearfix to main content area

https://gerrit.wikimedia.org/r/628789

matmarex edited projects, added Editing QA; removed Patch-For-Review.
ppelberg closed this task as Resolved.Nov 24 2020, 3:05 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 24 2020, 3:05 AM