Page MenuHomePhabricator

Add IPInfo popup to Special:Investigate
Open, LowPublic

Description

We'd like to add the IPInfo popup (T260604) to Special:Investigate. There are a few questions to address first:

Hover or button

Should we display the popup when the user hovers over an IP address, or when they click on a button next to the IP address?

  • If hover, what should the behaviour be for anonymous user links on touch devices?
  • If button, what should the highlighting behaviour be on the Compare tab? Currently, having a button in focus interferes with the highlighting.

Where should the popup go

On the Compare tab, presumably the popup should display in the IP column of the table:

image.png (1×920 px, 66 KB)

On the Timeline tab, should the popup display in the equivalent place, where the IP addresses are shown?

image.png (56×575 px, 11 KB)

Or should it be consistent with the other pages (e.g. history pages, Special:RecentChanges) and display by the user link?

image.png (240×651 px, 48 KB)

Event Timeline

From the description

Or should it be consistent with the other pages (e.g. history pages, Special:RecentChanges) and display by the user link?

I think we can keep it consistent with other pages and show the icon next to the IP address.

If button, what should the highlighting behaviour be on the Compare tab? Currently, having a button in focus interferes with the highlighting.

@Prtksxna: Could you comment on this? When you hover over a row in the table on the Compare tab, that row and similar rows in the column are highlighted. Clicking on the (i) button next to the IP address might interfere with this behaviour. Do we expect the row to remain highlighted if you click the (i) button? What if the user clicks the (i) button and then hovers over another row?

Do we expect the row to remain highlighted if you click the (i) button?

Yes, the row with the icon and all similar rows should remain highlighted.

What if the user clicks the (i) button and then hovers over another row?

The highlight should remain on the row (and similar rows) whose has been clicked. They would need to click outside the popup to dismiss it and get the usual hover-highlight behavior back.


I understand that there might be technical/a11y concerns here, lets talk about these and see if we should change our approach.