Page MenuHomePhabricator

jsonschema-tools should fail if new required field is added
Closed, ResolvedPublic

Description

In https://gerrit.wikimedia.org/r/c/schemas/event/secondary/+/628327/6, a new required field was added, but jsonschema-tools did not fail unit tests. New fields should always be optional to be backwards compatible, i.e. old events should still validate with the new schema version.

We should add a test case to jsonschema-tools to ensure that new fields are not required.

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Compatibility test fixes - required and enumrepos/data-engineering/jsonschema-tools!30ebysansgithub/fork/ottomata/requiredmaster
Customize query in GitLab