Page MenuHomePhabricator

VE Dialog on Test Instance: Search for parameters within a template
Closed, ResolvedPublic2 Estimated Story Points

Description

Note: should be implemented after T261504: VE on Test Instance: Change behavior for adding/removing params and before T263573: VE Dialog on the Test Instance: Add undocumented parameters

Requirements

  • Add a search field beneath the template name, when the template has parameters using OOUI SearchInputWidget (type=search)
  • Hide search field for templates without parameters
  • When search term is entered, filter parameters within that template and show results using the same criteria in the current search (under Add more information dropdown). Show results essentially means to hide all non-relevant parameters from the sidebar
  • Filter applies only to the parameter list in the sidebar, not to the template content on the right-hand side (all currently selected parameters should remain visible, not just those included after the filter)
  • When multiple templates/content exists, filter only within a single template. Do not hide the other templates/content.

Mock

With TemplateData-search widget.png (642×700 px, 58 KB)

With TemplateData - search input.png (642×700 px, 50 KB)

Search specs.png (656×531 px, 41 KB)

Event Timeline

Added specs and realized we can use an OOUI widget that has the clear button built in! So it should be included if it's possible to use this widget for this purpose

awight moved this task from Doing to Sprint Backlog on the WMDE-QWERTY-Sprint-2020-09-23 board.
awight added subscribers: Andrew-WMDE, awight.

Putting in the backlog while @Andrew-WMDE is away. (Maybe we need to make this a team norm?)

FYI, we're planning to reuse the matching logic from the "Add more information" fieldset.

When the search term doesn't match any parameters, we'll only see the template title, then a little empty space, then the next template title and parameters? Or should there be a "no matches found" label in this case?

When multiple templates are present, should each template include its own search field, which is always visible? Or should the search field only show on each template when a parameter belonging to it is in focus?

FYI, we're planning to reuse the matching logic from the "Add more information" fieldset.

Correct, sounds great.

Or should there be a "no matches found" label in this case?

I think this sound ideal, if it's not too much extra work would add this.

When multiple templates are present, should each template include its own search field, which is always visible?

For now would leave it always visible, for each template if added. Might be a bit counterintuitive, if it's not showing to figure out that I need to click a parameter in order to get the search field to appear.

Deployed to the test instance.

should there be a "no matches found" label in this case?

I skipped nice-to-haves for this iteration, but would like to come back later...

should there be a "no matches found" label in this case?

I skipped nice-to-haves for this iteration, but would like to come back later...

Okay, I got to this after all.

Two remaining bugs:

  • Doesn't show "no parameters found"
  • Search shows even when the template has no parameters.

Doesn't show "no parameters found"

If we're tight on time, this is acceptable to leave out for testing

Lena_WMDE changed the point value for this task from 8 to 2.
awight moved this task from Doing to Demo on the WMDE-QWERTY-Sprint-2020-10-21 board.
thiemowmde updated the task description. (Show Details)