Page MenuHomePhabricator

Standardise location of `global $wgFoo` in DevelopmentSettings.php
Open, Needs TriagePublic

Description

Most of the global references in DevelopmentSettings.php are at the top

A handful are scattered throughout the file

Can we standardise to having them all at the top?

Event Timeline

Reedy renamed this task from Standardise use of `global $wgFoo` in DevelopmentSettings.php to Standardise location of `global $wgFoo` in DevelopmentSettings.php.Sep 21 2020, 3:47 PM

Change 628874 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] DevelopmentSettings: Make sure all currently used global have a global call

https://gerrit.wikimedia.org/r/628874

Noting that patch doesn't actually do this... But at least standardises that all used globals have a global call...

Can we standardise to having them all at the top?

Or at least, in the section where they're used. Not some in lower sections, but globalised at the top...

The file is divided into separate sections. I placed globals intentionally in their own sections originally. +1 to cleaning up any drift from that.

The file is divided into separate sections. I placed globals intentionally in their own sections originally. +1 to cleaning up any drift from that.

Just being consistent would be good... So my patch probably mostly covers that

Change 628874 merged by jenkins-bot:
[mediawiki/core@master] DevelopmentSettings: Make sure all currently used global have a global call

https://gerrit.wikimedia.org/r/628874