Reedy renamed this task from Standardise use of `global $wgFoo` in DevelopmentSettings.php to Standardise location of `global $wgFoo` in DevelopmentSettings.php.Sep 21 2020, 3:47 PM

Partially follows up 853de300a3d85827015ca25131b6efdc31c4285a

DannyS712 subscribed.Sep 21 2020, 3:54 PM

Change 628874 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] DevelopmentSettings: Make sure all currently used global have a global call

https://gerrit.wikimedia.org/r/628874

gerritbot added a project: Patch-For-Review.Sep 21 2020, 4:09 PM

Noting that patch doesn't actually do this... But at least standardises that all used globals have a global call...

Can we standardise to having them all at the top?

Or at least, in the section where they're used. Not some in lower sections, but globalised at the top...

The file is divided into separate sections. I placed globals intentionally in their own sections originally. +1 to cleaning up any drift from that.

In T263475#6480857, @Krinkle wrote:

The file is divided into separate sections. I placed globals intentionally in their own sections originally. +1 to cleaning up any drift from that.

Just being consistent would be good... So my patch probably mostly covers that

Change 628874 merged by jenkins-bot:
[mediawiki/core@master] DevelopmentSettings: Make sure all currently used global have a global call

https://gerrit.wikimedia.org/r/628874

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 21 2020, 10:01 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 21 2020, 10:10 PM

Standardise location of `global $wgFoo` in DevelopmentSettings.phpOpen, Needs TriagePublicActions

Description

Details

Related Objects

Event Timeline

Standardise location of `global $wgFoo` in DevelopmentSettings.php
Open, Needs TriagePublic
Actions