Page MenuHomePhabricator
Create Task
Maniphest T263544

Shows gallery row when opening up the preview popup if there is enough space
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. on desktop browser
  2. go to https://wikimedia.github.io/wikipedia-preview/demo/articles/hindi.html
  3. hover the second link

Actual Results:

There is empty gallery row

Expected Results:

There is item in gallery row

Related Objects

Event Timeline

hueitan created this task.Sep 22 2020, 2:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 22 2020, 2:30 PM
hueitan added a comment.EditedSep 22 2020, 2:30 PM

PR is here https://github.com/wikimedia/wikipedia-preview/pull/66 (Discard the PR)

hueitan renamed this task from Shows empty gallery row when opening up the preview popup to Shows gallery row when opening up the preview popup if there is enough space.Sep 22 2020, 2:31 PM
SBisson moved this task from Backlog to Mobile-Prototype on the Wikipedia-Preview board.Sep 22 2020, 3:01 PM
SBisson edited projects, added Wikipedia-Preview (Mobile-Prototype); removed Wikipedia-Preview.
SBisson moved this task from Backlog to three on the Wikipedia-Preview (Mobile-Prototype) board.
hueitan moved this task from Code Review to Dev on the Inuka-Team (Kanban) board.Sep 22 2020, 6:54 PM
hueitan moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Sep 23 2020, 9:34 AM

New PR : https://github.com/wikimedia/wikipedia-preview/pull/68

AMuigai triaged this task as Medium priority.Sep 23 2020, 12:15 PM
SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Sep 23 2020, 2:42 PM
Jpita moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.Sep 24 2020, 10:54 AM
Jpita added a subscriber: Jpita.

moving this to done since it's being fixed on T263584

AMuigai moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.Sep 24 2020, 5:33 PM
AMuigai closed this task as Resolved.Sep 28 2020, 11:41 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL