Errors: Translation unit name <key-name> must not contain underscore or slash
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	DAlangi_WMF
	Sep 22 2020, 2:35 PM

Description

On this page: https://meta.wikimedia.org/w/index.php?title=Special:PageTranslation&target=Template%3AI18n%2FReports&do=mark, I'm seeing that I can't mark new strings for translations.

Screen Shot 2020-09-22 at 3.35.26 PM.png (1×2 px, 165 KB)

I do not have any underscores or slashes in the translation string indices. What are my doing wrong?

Impact

Any page with custom translation unit identifiers containing the letter n cannot be marked for translation.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Translate	wmf/1.36.0-wmf.10	+1 -1	Fix validation of translation unit section names
	mediawiki/extensions/Translate	master	+1 -1	Fix validation of translation unit section names

Customize query in gerrit

Related Objects

Mentioned Here: rETRAfa4900e1e602: Fix validation of translation unit section names

Event Timeline

DAlangi_WMF created this task.Sep 22 2020, 2:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 22 2020, 2:35 PM

DAlangi_WMF added a project: MediaWiki Language Extension Bundle.Sep 22 2020, 2:36 PM

All those section names contain the letter n. Our regexp is broken: https://3v4l.org/VrNvf

Nikerabbit moved this task from Quarter Backlog to Breaking bugs on the Language-Team (Language-2020-July-September) board.Sep 22 2020, 3:09 PM

Nikerabbit updated the task description. (Show Details)

Change 629257 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Fix validation of translation unit section names

https://gerrit.wikimedia.org/r/629257

gerritbot added a project: Patch-For-Review.Sep 23 2020, 6:10 AM

Nikerabbit claimed this task.Sep 23 2020, 6:10 AM

Nikerabbit moved this task from Breaking bugs to In Review on the Language-Team (Language-2020-July-September) board.

Nikerabbit updated the task description. (Show Details)

Change 629257 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix validation of translation unit section names

https://gerrit.wikimedia.org/r/629257

Nikerabbit changed the subtype of this task from "Task" to "Bug Report".Sep 23 2020, 7:45 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 23 2020, 8:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 23 2020, 8:10 AM

Change 629640 had a related patch set uploaded (by Abijeet Patro; owner: Nikerabbit):
[mediawiki/extensions/Translate@wmf/1.36.0-wmf.10] Fix validation of translation unit section names

https://gerrit.wikimedia.org/r/629640

gerritbot added a project: Patch-For-Review.Sep 24 2020, 9:53 AM

Change 629640 merged by jenkins-bot:
[mediawiki/extensions/Translate@wmf/1.36.0-wmf.10] Fix validation of translation unit section names

https://gerrit.wikimedia.org/r/629640

Mentioned in SAL (#wikimedia-operations) [2020-09-24T11:34:21Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.10/extensions/Translate/tag/TPSection.php: fa4900e1e6022e645be12505de30b696a9769e77: Fix validation of translation unit section names (T263546) (duration: 01m 07s)

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.10; 2020-09-22); removed MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 24 2020, 12:00 PM

I confirm that I no longer face this issue on Meta-Wiki. Problem has been resolved and if this is the case, I'll leave this for either @Nikerabbit or @abi_ to close the task. Thank you all for fixing this.

DAlangi_WMF awarded a token.Sep 24 2020, 12:06 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 24 2020, 12:10 PM