Page MenuHomePhabricator
Create Task
Maniphest T263583

Introduce a ParserCacheFactory
Closed, ResolvedPublic
Actions

Description

In order to be able to store Parsoid output, we need to introduce a ParserCacheFactory which would allow getting various ParserCaches for various cases (one for default parser, one for Parsoid). FlaggedRevs extension should be converted to use the factory mechanism instead of custom code with it's own custom ParserCache.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Clean up ParserCache construction and inject loggerPpchelkomediawiki/coremaster+66 -58
Use ParserCacheFactory to obtain a stable ParserCachePpchelkomediawiki/extensions/FlaggedRevsmaster+19 -90
Create ParserCacheFactory.Ppchelkomediawiki/coremaster+163 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pchelolo created this task.Sep 22 2020, 7:06 PM
• holger.knust moved this task from Inbox to Future Initiatives/Small Projects on the Platform Engineering board.Sep 22 2020, 8:09 PM
ssastry moved this task from Needs Triage to Non-Parsing-Team Tasks on the Parsoid board.Sep 22 2020, 9:29 PM
gerritbot added a comment.Sep 25 2020, 8:06 PM

Change 630261 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Create ParserCacheFactory.

https://gerrit.wikimedia.org/r/630261

gerritbot added a project: Patch-For-Review.Sep 25 2020, 8:06 PM
gerritbot added a comment.Sep 25 2020, 8:47 PM

Change 630278 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/FlaggedRevs@master] Use ParserCacheFactory to obtain a stable ParserCache

https://gerrit.wikimedia.org/r/630278

gerritbot added a comment.Sep 25 2020, 9:56 PM

Change 630299 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Clean up ParserCache construction and inject logger

https://gerrit.wikimedia.org/r/630299

daniel mentioned this in T244058: Strategy for storing parser output for "old revision" (Popular diffs and permalinks).Sep 28 2020, 9:32 AM
• Pchelolo claimed this task.Sep 28 2020, 3:08 PM
• Pchelolo edited projects, added: Platform Team Workboards (Green); removed: Platform Engineering.
• Pchelolo moved this task from Backlog to Waiting for Review on the Platform Team Workboards (Green) board.
gerritbot added a comment.Sep 28 2020, 4:13 PM

Change 630261 merged by jenkins-bot:
[mediawiki/core@master] Create ParserCacheFactory.

https://gerrit.wikimedia.org/r/630261

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 28 2020, 5:00 PM
gerritbot added a comment.Oct 1 2020, 4:23 PM

Change 630278 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Use ParserCacheFactory to obtain a stable ParserCache

https://gerrit.wikimedia.org/r/630278

ReleaseTaggerBot edited projects, added: MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED); removed: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Oct 1 2020, 5:00 PM
gerritbot added a comment.Oct 1 2020, 5:05 PM

Change 630299 merged by jenkins-bot:
[mediawiki/core@master] Clean up ParserCache construction and inject logger

https://gerrit.wikimedia.org/r/630299

Maintenance_bot removed a project: Patch-For-Review.Oct 1 2020, 5:11 PM
• Pchelolo closed this task as Resolved.Oct 2 2020, 12:27 AM
daniel mentioned this in T227776: General ParserCache service class for large "current" page-derived data.Nov 26 2020, 6:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits