Page MenuHomePhabricator

CI: Ensure SonarQubeBot code coverage metrics captures all test modes run during Parsoid CI tasks
Open, MediumPublic

Description

Parsoid/JS had a code coverage tool that tracked code coverage across the entire CI run that included mocha tests as well as parser tests.

As part of T263593: CI: Enable SonarCloud code quality tools on Parsoid patches, we are likely going to get some code coverage metrics. But, we need to ensure that the code coverage metrics is based on not just PHP unit test runs but also parser test runs (and other test runs like API tests, etc.) so we get a more reliable measure of code coverage and accurate sense of where test coverage gaps are.

Event Timeline

ssastry triaged this task as Medium priority.Sep 22 2020, 9:28 PM
ssastry created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 22 2020, 9:28 PM
ssastry moved this task from Needs Triage to Testing on the Parsoid board.Sep 22 2020, 9:29 PM
cscott added a subscriber: cscott.Oct 19 2020, 10:46 PM

One of the issues here is (AIUI) coverage metrics right now are only computed for *unit tests* not *integration tests*. The vast majority of parsoid's tests use the parserTests infrastructure, which is an integration test framework. This was done deliberately in the coverage configuration for some reasons I don't fully understand.