Page MenuHomePhabricator

Uncaught TypeError: Cannot read property 'localName' of null in emitLayoutShift
Closed, ResolvedPublic

Description

New in 1.36.0-wmf.9. 121 errors in last 12hrs. #2 trending error.

at URL1:77:50
at emitLayoutShift  URL1:76:718
at PerformanceObserver.<anonymous>  URL1:77:509

URL1: https://ca.m.wikipedia.org/w/load.php?lang=ca&modules=ext.centralNotice.bannerHistoryLogger%2CchoiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2ClargeBannerLimit%2ClegacySupport%2CstartUp%7Cext.centralauth.centralautologin%7Cext.eventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.quicksurveys.init%2Clib%7Cext.relatedArticles.readMore.bootstrap%2Cgateway%7Cjquery%2Coojs%2Coojs-router%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows%2Csite%7Cjquery.client%2Ccookie%2Cthrottle-debounce%7Cmediawiki.String%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Crouter%2Cstorage%2Ctemplate%2Cuser%2Cutil%2Cviewport%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmediawiki.template.mustache%7Cmediawiki.ui.anchor%7Cmobile.init%2Cstartup%7Cmobile.messageBox.styles%7Cmobile.ooui.icons%7Cmobile.pagelist.styles%7Cmobile.pagesummary.styles%7Cmobile.placeholder.images%7Cmobile.startup.images%7Cmw.config.values.wbDataBridgeConfig%7Cmw.externalguidance.init%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.indicators%7Cskins.minerva.icons.images.scripts%7Cskins.minerva.icons.images.scripts.misc%7Cskins.minerva.icons.page.issues.default.color%7Cskins.minerva.icons.page.issues.medium.color%7Cskins.minerva.icons.page.issues.uncolored%7Cskins.minerva.options%2Cscripts%7Cuser.defaults%7Cwikibase.client.data-bridge.init&skin=minerva&version=14046

Event Timeline

Restricted Application added a project: Performance-Team. · View Herald TranscriptSep 22 2020, 11:05 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
Gilles moved this task from Inbox to Doing on the Performance-Team board.
Gilles triaged this task as Medium priority.Tue, Sep 29, 11:01 AM

Change 630815 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/extensions/NavigationTiming@master] Make attribution source logic more defensive

https://gerrit.wikimedia.org/r/630815

Jdlrobson raised the priority of this task from Medium to Unbreak Now!.Tue, Oct 13, 11:24 PM

Around 6pm UTC this error spiked on commons.wikimedia.org
I'm a bit confused with the train right now and where this code is running so this may actually be high not UBN but I want to ire on the side of caution. Please drop to high if necessary but this is now our most prominent client side error in production by volume (3,887 every 12hrs, the second most prominent is only 762 errors every 12hrs)

8,965 in the last 12hrs (mostly commons)

Change 630815 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@master] Make attribution source logic more defensive

https://gerrit.wikimedia.org/r/630815

Change 634002 had a related patch set uploaded (by Krinkle; owner: Gilles):
[mediawiki/extensions/NavigationTiming@wmf/1.36.0-wmf.13] Make attribution source logic more defensive

https://gerrit.wikimedia.org/r/634002

Urbanecm added a subscriber: Urbanecm.EditedWed, Oct 14, 7:34 PM

EDIT: Nevermind, missed the parent task.

Change 634002 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@wmf/1.36.0-wmf.13] Make attribution source logic more defensive

https://gerrit.wikimedia.org/r/634002

Mentioned in SAL (#wikimedia-operations) [2020-10-14T22:01:31Z] <thcipriani@deploy1001> Synchronized php-1.36.0-wmf.13/extensions/NavigationTiming: BACON: [[gerrit:634002|Make attribution source logic more defensive]] T263599 (duration: 01m 05s)

Jdlrobson lowered the priority of this task from Unbreak Now! to Needs Triage.Wed, Oct 14, 10:21 PM

Looks like these are trailing off now.

Jdforrester-WMF closed this task as Resolved.Wed, Oct 14, 11:39 PM