Page MenuHomePhabricator
Create Task
Maniphest T263599

Uncaught TypeError: Cannot read property 'localName' of null in emitLayoutShift
Closed, ResolvedPublic
Actions

Assigned To
• Gilles
Authored By
Jdlrobson
Sep 22 2020, 11:04 PM
Tags
Referenced Files
F32386031: Screen Shot 2020-10-15 at 3.03.20 PM.png
Oct 15 2020, 10:04 PM
F32385079: Screen Shot 2020-10-14 at 3.20.52 PM.png
Oct 14 2020, 10:21 PM
F32383852: Screen Shot 2020-10-13 at 4.21.18 PM.png
Oct 13 2020, 11:24 PM
Subscribers
Agusbou2015
Aklapper
Jdlrobson
Krinkle
Masumrezarock100
Urbanecm

Description

New in 1.36.0-wmf.9. 121 errors in last 12hrs. #2 trending error.

at URL1:77:50
at emitLayoutShift  URL1:76:718
at PerformanceObserver.<anonymous>  URL1:77:509

URL1: https://ca.m.wikipedia.org/w/load.php?lang=ca&modules=ext.centralNotice.bannerHistoryLogger%2CchoiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2ClargeBannerLimit%2ClegacySupport%2CstartUp%7Cext.centralauth.centralautologin%7Cext.eventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.quicksurveys.init%2Clib%7Cext.relatedArticles.readMore.bootstrap%2Cgateway%7Cjquery%2Coojs%2Coojs-router%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows%2Csite%7Cjquery.client%2Ccookie%2Cthrottle-debounce%7Cmediawiki.String%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Crouter%2Cstorage%2Ctemplate%2Cuser%2Cutil%2Cviewport%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmediawiki.template.mustache%7Cmediawiki.ui.anchor%7Cmobile.init%2Cstartup%7Cmobile.messageBox.styles%7Cmobile.ooui.icons%7Cmobile.pagelist.styles%7Cmobile.pagesummary.styles%7Cmobile.placeholder.images%7Cmobile.startup.images%7Cmw.config.values.wbDataBridgeConfig%7Cmw.externalguidance.init%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.indicators%7Cskins.minerva.icons.images.scripts%7Cskins.minerva.icons.images.scripts.misc%7Cskins.minerva.icons.page.issues.default.color%7Cskins.minerva.icons.page.issues.medium.color%7Cskins.minerva.icons.page.issues.uncolored%7Cskins.minerva.options%2Cscripts%7Cuser.defaults%7Cwikibase.client.data-bridge.init&skin=minerva&version=14046

Details

SubjectRepoBranchLines +/-
Make attribution source logic more defensivemediawiki/extensions/NavigationTimingwmf/1.36.0-wmf.13+40 -8
Make attribution source logic more defensivemediawiki/extensions/NavigationTimingmaster+40 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Sep 22 2020, 11:04 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptSep 22 2020, 11:05 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
Jdlrobson moved this task from Untriaged to Sep 2020 on the Wikimedia-production-error board.Sep 22 2020, 11:05 PM
Krinkle subscribed.Sep 28 2020, 6:23 PM

See also T263047: Uncaught TypeError: Cannot read property 'node' of undefined.

• Gilles claimed this task.Sep 28 2020, 6:23 PM
• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.
• Gilles triaged this task as Medium priority.Sep 29 2020, 11:01 AM
gerritbot added a comment.Sep 29 2020, 12:30 PM

Change 630815 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/extensions/NavigationTiming@master] Make attribution source logic more defensive

https://gerrit.wikimedia.org/r/630815

gerritbot added a project: Patch-For-Review.Sep 29 2020, 12:30 PM
Umherirrender added a project: JavaScript.Oct 5 2020, 5:06 PM
Jdlrobson raised the priority of this task from Medium to Unbreak Now!.Oct 13 2020, 11:24 PM

Around 6pm UTC this error spiked on commons.wikimedia.org
I'm a bit confused with the train right now and where this code is running so this may actually be high not UBN but I want to ire on the side of caution. Please drop to high if necessary but this is now our most prominent client side error in production by volume (3,887 every 12hrs, the second most prominent is only 762 errors every 12hrs)

Screen Shot 2020-10-13 at 4.21.18 PM.png (374×2 px, 58 KB)

Jdlrobson added a parent task: T263179: 1.36.0-wmf.13 deployment blockers.Oct 14 2020, 6:17 PM

8,965 in the last 12hrs (mostly commons)

gerritbot added a comment.Oct 14 2020, 6:35 PM

Change 630815 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@master] Make attribution source logic more defensive

https://gerrit.wikimedia.org/r/630815

gerritbot added a comment.Oct 14 2020, 6:38 PM

Change 634002 had a related patch set uploaded (by Krinkle; owner: Gilles):
[mediawiki/extensions/NavigationTiming@wmf/1.36.0-wmf.13] Make attribution source logic more defensive

https://gerrit.wikimedia.org/r/634002

Krinkle merged a task: T265395: Uncaught TypeError: node.className.replace is not a function.Oct 14 2020, 6:39 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Oct 14 2020, 7:00 PM
Urbanecm subscribed.EditedOct 14 2020, 7:34 PM

EDIT: Nevermind, missed the parent task.

Agusbou2015 subscribed.Oct 14 2020, 8:18 PM
gerritbot added a comment.Oct 14 2020, 9:51 PM

Change 634002 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@wmf/1.36.0-wmf.13] Make attribution source logic more defensive

https://gerrit.wikimedia.org/r/634002

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.13; 2020-10-12); removed MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Oct 14 2020, 10:00 PM
Stashbot added a comment.Oct 14 2020, 10:01 PM

Mentioned in SAL (#wikimedia-operations) [2020-10-14T22:01:31Z] <thcipriani@deploy1001> Synchronized php-1.36.0-wmf.13/extensions/NavigationTiming: BACON: [[gerrit:634002|Make attribution source logic more defensive]] T263599 (duration: 01m 05s)

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2020, 10:10 PM
Jdlrobson lowered the priority of this task from Unbreak Now! to Needs Triage.Oct 14 2020, 10:21 PM

Looks like these are trailing off now.

Screen Shot 2020-10-14 at 3.20.52 PM.png (310×2 px, 58 KB)

Jdforrester-WMF closed this task as Resolved.Oct 14 2020, 11:39 PM
Jdlrobson added a comment.Oct 15 2020, 10:04 PM

Screen Shot 2020-10-15 at 3.03.20 PM.png (344×2 px, 68 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL