Page MenuHomePhabricator
Create Task
Maniphest T263600

Unable to get property 'currentTime' of undefined or null reference
Closed, ResolvedPublic
Actions

Description

82 errors. Code relates to logging - so this code is not likely functioning.

at mw.EmbedPlayerNative.waitForPositiveCurrentTime  URL1:157:989
at Anonymous function  URL1:157:619

URL1: https://commons.wikimedia.org/w/load.php?lang=en&modules=fullScreenApi%7Cjquery.debouncedresize%2CembedMenu%2ChoverIntent%7Cjquery.ui.touchPunch%7Cmediawiki.UtilitiesTime%2CabsoluteUrl%2Cclient%7Cmediawiki.language.names%7Cmw.Api%2CEmbedPlayer%2CEmbedPlayerNative%2CEmbedTypes%2CMediaElement%2CMediaPlayer%2CMediaPlayers%2CMediaSource%2CMediaWikiPlayerSupport%2CTextSource%2CTimedText%2CajaxProxy&skin=vector&version=17tqc

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
MWEmbedPlayer: Don't try to work on videos that aren't in the DOMmediawiki/extensions/TimedMediaHandlermaster+5 -0
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Sep 22 2020, 11:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 22 2020, 11:09 PM
BPirkle moved this task from Untriaged to Sep 2020 on the Wikimedia-production-error board.Sep 23 2020, 6:43 PM
Umherirrender added a project: JavaScript.Oct 5 2020, 5:08 PM
Jdlrobson triaged this task as High priority.Jan 12 2021, 8:56 PM

Word of warning: we will likely be deploying error logging to English Wikipedia this month, increasing the volume of errors into our pipeline, and as one of our leading error messages there is a small risk that this may become UBN priority if not addressed prior to that.

gerritbot added a comment.Feb 25 2021, 4:18 PM

Change 666945 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/TimedMediaHandler@master] Fixes Unable to get property 'currentTime' of undefined or null reference

https://gerrit.wikimedia.org/r/666945

gerritbot added a project: Patch-For-Review.Feb 25 2021, 4:18 PM
gerritbot added a comment.Feb 25 2021, 8:32 PM

Change 666945 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] MWEmbedPlayer: Don't try to work on videos that aren't in the DOM

https://gerrit.wikimedia.org/r/666945

Jdlrobson closed this task as Resolved.Feb 25 2021, 8:56 PM
Jdlrobson claimed this task.

Will reopen if the error doesn't disappear with next deploy. thanks James!

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Feb 25 2021, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 25 2021, 9:10 PM
Jdlrobson added a comment.Mar 4 2021, 4:29 PM

LGTM

Screen Shot 2021-03-04 at 8.29.44 AM.png (816×2 px, 156 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits