ApiQueryGlobalUsage.php Undefined index error when accessing $pageIds
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.9

message

PHP Notice: Undefined index: 94thpedal.JPG

Impact

Occasional bursts of screen fulls of these errors in logspam-watch output.

Notes

Details

Request ID: fbe907c0-ede4-460d-b40c-fd7dfa543d70
Request URL: https://commons.wikimedia.org/w/api.php?action=query&titles=File:94&format=json&prop=globalusage&gusite=enwiki%7Cenwikibooks%7Cenwikinews%7Cenwikiquote%7Cenwikisource%7Cenwikiversity%7Cenwikivoyage%7Cenwiktionary&guprop=pageid%7Curl&gulimit=500

Stack Trace

exception.trace

#0 /srv/mediawiki/php-1.36.0-wmf.9/extensions/GlobalUsage/includes/ApiQueryGlobalUsage.php(57): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.9/includes/api/ApiQuery.php(263): ApiQueryGlobalUsage->execute()
#2 /srv/mediawiki/php-1.36.0-wmf.9/includes/api/ApiMain.php(1600): ApiQuery->execute()
#3 /srv/mediawiki/php-1.36.0-wmf.9/includes/api/ApiMain.php(536): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.36.0-wmf.9/includes/api/ApiMain.php(507): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.36.0-wmf.9/api.php(90): ApiMain->execute()
#6 /srv/mediawiki/php-1.36.0-wmf.9/api.php(45): wfApiMain()
#7 /srv/mediawiki/w/api.php(3): require(string)
#8 {main}

Subject	Repo	Branch	Lines +/-
Fix database query from api for number-only titles	mediawiki/extensions/GlobalUsage	master	+4 -20
ApiQueryGlobalUsage: handle undefined indexes	mediawiki/extensions/GlobalUsage	wmf/1.36.0-wmf.10	+17 -0
ApiQueryGlobalUsage: handle undefined indexes	mediawiki/extensions/GlobalUsage	master	+17 -0

Customize query in gerrit

Related Objects

Mentioned In: T257978: 1.36.0-wmf.10 deployment blockers
T263675: Undefined class constant 'LIMIT'
Mentioned Here: T263675: Undefined class constant 'LIMIT'

Event Timeline

dancy created this task.Sep 22 2020, 11:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 22 2020, 11:09 PM

dancy triaged this task as Low priority.Sep 22 2020, 11:10 PM

Reedy added a project: GlobalUsage.Sep 22 2020, 11:12 PM

dancy updated the task description. (Show Details)Sep 22 2020, 11:12 PM

added as blocker even though this isn't new. It's currently the highest frequency logspam in kibana.

and yet the code in question hasn't been touched since 2009:

https://phabricator.wikimedia.org/diffusion/EGUS/browse/master/includes/ApiQueryGlobalUsage.php$57

DannyS712 subscribed.Sep 23 2020, 2:21 PM

train blockers are UBNs

So the code in question appears to be ok, I think something changed in the code it's calling so the assumption that pageId would be valid is no longer valid.

Requests are generating a lot of noise here. For example the 1 request-id in this task generated 164 notices https://logstash.wikimedia.org/goto/0aa65e4883b273a1497897615ab6a081

Change 629391 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalUsage@master] ApiQueryGlobalUsage: handle undefined indexes

https://gerrit.wikimedia.org/r/629391

gerritbot added a project: Patch-For-Review.Sep 23 2020, 4:08 PM

BPirkle moved this task from Untriaged to Sep 2020 on the Wikimedia-production-error board.Sep 23 2020, 6:43 PM

Change 629399 had a related patch set uploaded (by Ahmon Dancy; owner: DannyS712):
[mediawiki/extensions/GlobalUsage@wmf/1.36.0-wmf.10] ApiQueryGlobalUsage: handle undefined indexes

https://gerrit.wikimedia.org/r/629399

Change 629391 merged by jenkins-bot:
[mediawiki/extensions/GlobalUsage@master] ApiQueryGlobalUsage: handle undefined indexes

https://gerrit.wikimedia.org/r/629391

Change 629399 merged by jenkins-bot:
[mediawiki/extensions/GlobalUsage@wmf/1.36.0-wmf.10] ApiQueryGlobalUsage: handle undefined indexes

https://gerrit.wikimedia.org/r/629399

Mentioned in SAL (#wikimedia-operations) [2020-09-23T20:42:50Z] <dancy> dancy@deploy1001 Started scap: Deploying fixes for T263601 and T263675 to 1.36.0-wmf.10

Stashbot mentioned this in T263675: Undefined class constant 'LIMIT'.Sep 23 2020, 8:42 PM

DannyS712 removed a project: Patch-For-Review.Sep 23 2020, 8:43 PM

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.11; 2020-09-29); removed MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 23 2020, 9:00 PM

dancy removed a parent task: T257978: 1.36.0-wmf.10 deployment blockers.Sep 23 2020, 11:30 PM

DannyS712 mentioned this in T257978: 1.36.0-wmf.10 deployment blockers.Sep 23 2020, 11:46 PM

Is this resolved?

ApiQueryGlobalUsage::execute() has been modified to defend against the undefined index error but the root cause has not been resolved.

Production breakage / train blocker part resolved, so de-escalating.

daniel triaged this task as Medium priority.Sep 29 2020, 8:46 PM

daniel added a project: Platform Team Workboards (Clinic Duty Team).

daniel moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.Sep 29 2020, 8:53 PM

Change 636148 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/GlobalUsage@master] Fix database query from api for number-only titles

https://gerrit.wikimedia.org/r/636148

gerritbot added a project: Patch-For-Review.Oct 24 2020, 10:32 PM

The bad query can also results in WMFTimeoutException, I have produce one while looking at this bug. If you found it in the logs/logstash, there is no need to report.

Change 636148 merged by jenkins-bot:
[mediawiki/extensions/GlobalUsage@master] Fix database query from api for number-only titles

https://gerrit.wikimedia.org/r/636148

Umherirrender closed this task as Resolved.Dec 7 2020, 4:23 PM

Umherirrender claimed this task.

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.21; 2020-12-08); removed MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Dec 7 2020, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 7 2020, 5:10 PM