Page MenuHomePhabricator

findBadBlobs.php unnecessarily requires cleanupTable.inc
Closed, ResolvedPublic

Description

The maintenance/findBadBlobs.php script requires cleanupTable.inc rather than Maintenance.php. Unlike several other maintenance scripts that include cleanupTable.inc, the FindBadBlobs class does not derive from TableCleanup, and does not otherwise reference anything from cleanupTable.inc. Likely this is either a cut-and-paste error, or a leftover from initial development that ended up going a different direction.

Because cleanupTable.inc requires Maintenance.php, everything still works. But including cleanupTable.inc gives the incorrect impression that findBadBlobs.php uses something from it, and is ever-so-slightly less efficient.

The simple fix is to change the require to bring in Maintenance.php instead.

Event Timeline

BPirkle created this task.Sep 23 2020, 12:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2020, 12:32 AM

Change 629239 had a related patch set uploaded (by BPirkle; owner: BPirkle):
[mediawiki/core@master] Have findBadBlobs.php require Maintenance.php rather than cleanupTable.inc

https://gerrit.wikimedia.org/r/629239

Change 629192 had a related patch set uploaded (by Reedy; owner: BPirkle):
[mediawiki/core@REL1_35] Have findBadBlobs.php require Maintenance.php rather than cleanupTable.inc

https://gerrit.wikimedia.org/r/629192

Change 629192 merged by jenkins-bot:
[mediawiki/core@REL1_35] Have findBadBlobs.php require Maintenance.php rather than cleanupTable.inc

https://gerrit.wikimedia.org/r/629192

Reedy triaged this task as Low priority.Sep 23 2020, 12:59 AM

Change 629239 merged by jenkins-bot:
[mediawiki/core@master] Have findBadBlobs.php require Maintenance.php rather than cleanupTable.inc

https://gerrit.wikimedia.org/r/629239

Reedy closed this task as Resolved.Sep 23 2020, 1:02 AM
Reedy removed a project: Patch-For-Review.