WatchedItemStoreIntegrationTest::testDuplicateAllAssociatedEntries Failed asserting that two strings are identical
Closed, ResolvedPublic
Actions

Description

Seen on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/629192/

https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php73-docker/629/console

then passed on immediately after on

https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php73-docker/630/console

So the test seems flaky

01:47:51 1) WatchedItemStoreIntegrationTest::testDuplicateAllAssociatedEntries
01:47:51 Failed asserting that two strings are identical.
01:47:51 --- Expected
01:47:51 +++ Actual
01:47:51 @@ @@
01:47:51 -'20210323004714'
01:47:51 +'20210323004713'
01:47:51 
01:47:51 /workspace/src/tests/phpunit/includes/watcheditem/WatchedItemStoreIntegrationTest.php:372
01:47:51 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:446
01:47:51 /workspace/src/maintenance/doMaintenance.php:107

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+4 -0	Set fake time, to avoid flaky tests
	mediawiki/core	REL1_35	+4 -0	Set fake time, to avoid flaky tests

Customize query in gerrit

Event Timeline

Reedy created this task.Sep 23 2020, 12:58 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 23 2020, 12:58 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Might be solved by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/626923 ?

Change 626923 had a related patch set uploaded (by Ammarpad; owner: Samwilson):
[mediawiki/core@master] Set fake time, to avoid flaky tests

https://gerrit.wikimedia.org/r/626923

gerritbot added a project: Patch-For-Review.Sep 23 2020, 1:33 AM

Change 629193 had a related patch set uploaded (by Reedy; owner: Samwilson):
[mediawiki/core@REL1_35] Set fake time, to avoid flaky tests

https://gerrit.wikimedia.org/r/629193

Change 626923 merged by jenkins-bot:
[mediawiki/core@master] Set fake time, to avoid flaky tests

https://gerrit.wikimedia.org/r/626923

Change 629193 merged by jenkins-bot:
[mediawiki/core@REL1_35] Set fake time, to avoid flaky tests

https://gerrit.wikimedia.org/r/629193

ReleaseTaggerBot added projects: MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 23 2020, 3:00 AM

Umherirrender closed this task as Resolved.Sep 24 2020, 6:40 PM

Umherirrender assigned this task to Samwilson.

WatchedItemStoreIntegrationTest::testDuplicateAllAssociatedEntries Failed asserting that two strings are identicalClosed, ResolvedPublicActions

Description

Details

Event Timeline

WatchedItemStoreIntegrationTest::testDuplicateAllAssociatedEntries Failed asserting that two strings are identical
Closed, ResolvedPublic
Actions