Maniphest T263607

Content nodes are lost when bolded in VE
Closed, ResolvedPublic
Actions

Description

Behavior

Open VE in any context (e.g. Reply Tool's visual mode, Flow's Visual editing mode or the full page visual editor)
Insert any content node in the middle of a paragraph (it must have some text on both sides) – we initially noticed this with Flow and DiscussionTools mentions, but it also affects e.g. references, HTML comments, etc.
Select the entire paragraph, with the content node in the middle
Press ⌘ + B

Actual

❗️Notice the content node you highlighted in "Step 3" has been deleted, the rest of the text is bolded
After pressing Enter, two snowmen ☃ appear

This video demonstrates this issue: https://www.youtube.com/watch?v=VFc7_8AP0dU

Expected

✅Notice the content node is bolded along with the rest of the text

Environment

Platform: Desktop
Browser: Chrome

Done

"Expected" behavior is implemented

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (0a5e284c7)	mediawiki/extensions/VisualEditor	master	+1 -1
	Revert "ve.ce.Surface: Debounce onModelDocumentUpdate"	VisualEditor/VisualEditor	master	+1 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T276497 Scale DiscussionTools to all projects
Open	None	T251207 [Epic] Scale DiscussionTools to all Wikipedias
Resolved	None	T262331 [Release ticket] Make Reply Tool available as opt-out preference at all Wikipedias
Open	None	T233443 [Epic] Reply Tool
Resolved	ppelberg	T249394 Deploy Reply Tool as opt-out Preference at the Arabic, Czech and Hungarian Wikipedias
Resolved	Esanders	T263607 Content nodes are lost when bolded in VE

Event Timeline

ppelberg created this task.Sep 23 2020, 1:25 AM

ppelberg updated the task description. (Show Details)Sep 23 2020, 4:43 AM

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Sep 23 2020, 4:46 AM

ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.

matmarex renamed this task from Text is lost when bolded in VE to Content nodes are lost when bolded in VE .Sep 23 2020, 5:17 PM

matmarex updated the task description. (Show Details)

Bisect blames one of my recent performance optimisations: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/623411

Change 629392 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Revert "ve.ce.Surface: Debounce onModelDocumentUpdate"

https://gerrit.wikimedia.org/r/629392

gerritbot added a project: Patch-For-Review.Sep 23 2020, 5:23 PM

Esanders claimed this task.Sep 23 2020, 5:23 PM

Esanders moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.

ppelberg updated the task description. (Show Details)Sep 23 2020, 5:24 PM

ppelberg updated the task description. (Show Details)

ppelberg mentioned this in T249394: Deploy Reply Tool as opt-out Preference at the Arabic, Czech and Hungarian Wikipedias.Sep 23 2020, 6:12 PM

Change 629392 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Revert "ve.ce.Surface: Debounce onModelDocumentUpdate"

https://gerrit.wikimedia.org/r/629392

Maintenance_bot removed a project: Patch-For-Review.Sep 23 2020, 7:10 PM

Change 629450 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0a5e284c7)

https://gerrit.wikimedia.org/r/629450

gerritbot added a project: Patch-For-Review.Sep 23 2020, 7:11 PM

Change 629450 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0a5e284c7)

https://gerrit.wikimedia.org/r/629450

matmarex mentioned this in T262515: Deleting extraneous line breaks in a section creates a duplicate paragraph when using visual editor on mobile.Sep 23 2020, 7:36 PM

matmarex edited projects, added Editing QA; removed Patch-For-Review.Sep 23 2020, 7:58 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 23 2020, 8:00 PM

Esanders mentioned this in T261662: undo/redo is slow on large documents.Sep 23 2020, 8:04 PM

Esanders triaged this task as High priority.Sep 23 2020, 8:44 PM

Esanders added a project: Regression.

ppelberg moved this task from Inbox to High Priority on the Editing QA board.Oct 1 2020, 9:56 PM

Ryasmeen edited projects, added Verified; removed Editing QA.Oct 2 2020, 8:36 PM

Pols12 subscribed.Oct 7 2020, 8:18 AM

I think this is the same bug: pressing CTRL + I (for italics) produce the same bug.

Plus, for text-only nodes, pressing CTRL+I/B make the cursor come back to paragraph origin.

• Catrope merged a task: T265186: Bolding an inline template deletes it and inserts snowmen.Oct 9 2020, 11:58 PM

• Catrope subscribed.

matmarex merged a task: T265225: Character entity references (e.g. –) are corrupted when changing text style (e.g. bolding, italicizing, underlining).Oct 12 2020, 2:38 PM

matmarex added a subscriber: CWenger.

IKhitron subscribed.Oct 12 2020, 5:10 PM

JTannerWMF added a project: Editing QA.Nov 23 2020, 7:37 PM

Ryasmeen removed a project: Editing QA.Nov 24 2020, 12:36 AM

JTannerWMF moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Nov 25 2020, 6:28 PM

ppelberg closed this task as Resolved.Dec 5 2020, 2:59 AM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 5 2020, 2:59 AM

Content nodes are lost when bolded in VE Closed, ResolvedPublicActions