Page MenuHomePhabricator

Reuse dialog and WindowManager for StartEditingDialog
Closed, InvalidPublic

Description

Every time you open the StartEditingDialog, it's rebuilt from scratch, with a new WindowManager too. If you open and close the StartEditingDialog many times, you'll end up with many copies of it in the DOM, each in their own WindowManager.

Once T263608: Variant C: don't personalize onboarding dialog when accessed from info icon is done, it'll be possible to open the StartEditingDialog in different contexts on the same page (e..g from the welcome popup and from the info button), so we'll need to move some/all of the config settings from the constructor to getSetupProcess.