Page MenuHomePhabricator
Create Task
Maniphest T263611

[wmf.10] mobile - mw-ge-small-task-card-pageviews skeleton persistently displayed in post-edit dialog
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Tgr
Authored By
Etonkovidova
Sep 23 2020, 4:12 AM
Tags
Referenced Files
F32361088: Screen Shot 2020-09-23 at 10.45.21 AM.png
Sep 23 2020, 5:46 PM
F32360447: Screen Shot 2020-09-22 at 9.00.44 PM.png
Sep 23 2020, 4:12 AM
F32360445: Screen Shot 2020-09-22 at 9.00.21 PM.png
Sep 23 2020, 4:12 AM
Subscribers
Aklapper
Catrope
Etonkovidova
kostajh
MMiller_WMF
Tgr

Description

Steps to Reproduce:

  1. On mobile testwiki wmf.10 go to SE article and edit it.
  2. The post-edit dialog will display mw-ge-small-task-card-pageviews skeleton persistently

The issue is displayed in a browser emulator (Chrome browser) and on a real device - iPhone 6s (iOS 13.7)

Screen Shot 2020-09-22 at 9.00.21 PM.png (482×425 px, 71 KB)

Screen Shot 2020-09-22 at 9.00.44 PM.png (375×455 px, 74 KB)

Details

SubjectRepoBranchLines +/-
Mark pageviews as not used in the mobile postedit noticemediawiki/extensions/GrowthExperimentsmaster+1 -0
Mark pageviews as not used in the mobile postedit noticemediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.10+1 -0
Fix GrowthTasksApi lazy-loading flags for pages with no viewsmediawiki/extensions/GrowthExperimentsmaster+15 -4
Fix GrowthTasksApi lazy-loading flags for pages with no viewsmediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.10+15 -4
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Sep 23 2020, 4:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2020, 4:12 AM
gerritbot added a comment.Sep 23 2020, 5:56 AM

Change 629255 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix GrowthTasksApi lazy-loading flags for pages with no views

https://gerrit.wikimedia.org/r/629255

gerritbot added a project: Patch-For-Review.Sep 23 2020, 5:56 AM
gerritbot added a comment.Sep 23 2020, 5:59 AM

Change 629256 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Mark pageviews as not used in the mobile postedit notice

https://gerrit.wikimedia.org/r/629256

Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.EditedSep 23 2020, 6:01 AM
Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

This will need to be backported tomorrow. Thanks for catching the bug!

Tgr claimed this task.Sep 23 2020, 6:18 AM
gerritbot added a comment.Sep 23 2020, 11:13 AM

Change 629201 had a related patch set uploaded (by Kosta Harlan; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.10] Mark pageviews as not used in the mobile postedit notice

https://gerrit.wikimedia.org/r/629201

gerritbot added a comment.Sep 23 2020, 11:14 AM

Change 629202 had a related patch set uploaded (by Kosta Harlan; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.10] Fix GrowthTasksApi lazy-loading flags for pages with no views

https://gerrit.wikimedia.org/r/629202

gerritbot added a comment.Sep 23 2020, 11:15 AM

Change 629256 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Mark pageviews as not used in the mobile postedit notice

https://gerrit.wikimedia.org/r/629256

gerritbot added a comment.Sep 23 2020, 11:21 AM

Change 629255 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix GrowthTasksApi lazy-loading flags for pages with no views

https://gerrit.wikimedia.org/r/629255

gerritbot added a comment.Sep 23 2020, 11:30 AM

Change 629202 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.10] Fix GrowthTasksApi lazy-loading flags for pages with no views

https://gerrit.wikimedia.org/r/629202

gerritbot added a comment.Sep 23 2020, 11:31 AM

Change 629201 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.10] Mark pageviews as not used in the mobile postedit notice

https://gerrit.wikimedia.org/r/629201

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 23 2020, 11:32 AM

Backporting to wmf.10 at the moment.

Stashbot added a comment.Sep 23 2020, 11:49 AM

Mentioned in SAL (#wikimedia-operations) [2020-09-23T11:49:26Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.10/extensions/GrowthExperiments/modules/help/ext.growthExperiments.PostEdit.js: rEGRE1ab31a966edc: Mark pageviews as not used in the mobile postedit notice (T263611) (duration: 01m 06s)

Stashbot added a comment.Sep 23 2020, 11:51 AM

Mentioned in SAL (#wikimedia-operations) [2020-09-23T11:51:21Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.10/extensions/GrowthExperiments/modules/homepage/suggestededits/ext.growthExperiments.Homepage.GrowthTasksApi.js: rEGRE73b5ce82b391: Fix GrowthTasksApi lazy-loading flags for pages with no views (T263611) (duration: 01m 05s)

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 23 2020, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 23 2020, 12:10 PM
Etonkovidova closed this task as Resolved.Sep 23 2020, 5:46 PM

Checked in testwiki wmf.10 - the issue is fixed.

Screen Shot 2020-09-23 at 10.45.21 AM.png (548×377 px, 61 KB)

Sgs mentioned this in T294835: Positive reinforcement: Revise skeleton state and behaviour of the Post-edit dialog.Feb 15 2023, 11:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits