Description
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/IPInfo | master | +3 -1 | Make IPInfo tool available on Special:RecentChanges |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | TThoabala | T263636 Make IPInfo tool available on Special:RecentChanges [M] | |||
| Resolved | Tchanders | T263634 Make IPInfo tool available on Special:Log page | |||
| Resolved | Tchanders | T263635 Allow IPInfo to return data for an IP address that is the target of a log entry |
Event Timeline
Change 725373 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):
[mediawiki/extensions/IPInfo@master] Make IPInfo tool available on Special:RecentChanges
Change 725373 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Make IPInfo tool available on Special:RecentChanges
I noticed two things during review that I didn't feel should block merging @TThoabala's change but should be considered part of this task:
- @Prtksxna @Niharika: Special:RecentChanges groups multiple edits in quick succession to the same page and displays them as a single collapsed line item with the user's name still visible. Should IP Info's (i) button be present for this line?
Further, if you expand the collapsed line item, then each line shows IP Info's (i) button. Is this correct?
| Collapsed | Expanded |
|---|---|
 |  |
- Special:RecentChanges polls for new changes every second. You can either manually update the page when new changes are detected or enable the live update feature. In either case, however, when the page is updated, all of IP Info's (i) buttons disappear:
Verified that IP info box shows on the Recent Changes page after.
updated page ur: https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&hideWikibase=1&limit=50&days=7&urlversion=2
Screen shot of IP Info:
Yep, it should. I've created T293332: IP Info icon should be present on collapsed lines on RecentChanges [M]
Further, if you expand the collapsed line item, then each line shows IP Info's (i) button. Is this correct?
Yes, this is correct.
- Special:RecentChanges polls for new changes every second. You can either manually update the page when new changes are detected or enable the live update feature. In either case, however, when the page is updated, all of IP Info's (i) buttons disappear:
Oh no, this shouldn't be happening. Created T293333: IP Info icon shouldn't disappear after Recent Changes has loaded new changes [M].
Thanks for all the details and screenshots @phuedx