Page MenuHomePhabricator
Create Task
Maniphest T263638

Add placeholder text to Special:Block 'Username or IP address' field
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Add placeholder text to Special:Block similar to that in Special:Investigate:

Screen Shot 2019-11-18 at 13.44.47.png (1,422×700 px, 64 KB)
image.png (1,468×366 px, 47 KB)
Special:InvestigateSpecial:Block

Note that the Special:Block field can also accept IP ranges.

Proposed placeholder text: UserName, 1.1.1.42 or 1.1.1.42/16

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update label and placeholder text for Special:Block targetSTranmediawiki/coremaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Sep 23 2020, 1:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2020, 1:26 PM
Tchanders mentioned this in T238603: Placeholder text on Special:Investigate seems unnecessary.Sep 23 2020, 1:27 PM
• Niharika moved this task from Untriaged to Onboarding Tasks on the Anti-Harassment-Team board.Sep 23 2020, 4:35 PM
• Niharika moved this task from Onboarding Tasks to Triage/To be Estimated on the Anti-Harassment-Team board.Nov 4 2020, 4:51 PM
• Niharika triaged this task as Medium priority.Mar 31 2021, 12:12 PM
• Niharika updated the task description. (Show Details)
• Niharika set the point value for this task to 1.Mar 31 2021, 4:10 PM
• Niharika moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.
• Prtksxna mentioned this in T278980: Special:Block: Update label.Mar 31 2021, 4:24 PM
• Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment-Team board.Mar 31 2021, 4:53 PM
• Niharika edited projects, added: Anti-Harassment-Team (The Letter Song); removed: Anti-Harassment-Team.
STran claimed this task.Apr 1 2021, 6:05 AM
gerritbot added a comment.Apr 1 2021, 6:06 AM

Change 676183 had a related patch set uploaded (by STran; author: STran):

[mediawiki/core@master] Update label and placeholder text for Special:Block target

https://gerrit.wikimedia.org/r/676183

gerritbot added a project: Patch-For-Review.Apr 1 2021, 6:06 AM
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.Apr 1 2021, 6:52 AM
STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Apr 1 2021, 8:57 AM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (The Letter Song) board.Apr 1 2021, 11:37 AM
gerritbot added a comment.Apr 1 2021, 6:23 PM

Change 676183 merged by jenkins-bot:

[mediawiki/core@master] Update label and placeholder text for Special:Block target

https://gerrit.wikimedia.org/r/676183

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.38; 2021-04-06).Apr 1 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 1 2021, 7:10 PM
STran added a subscriber: • Prtksxna.Apr 6 2021, 11:16 AM

@Prtksxna Someone pointed out that "Username" is the correct casing. I assume then that both Special:Block and Special:Investigate: should be updated to reflect this?

• Prtksxna added a comment.Apr 6 2021, 11:22 AM
In T263638#6975831, @STran wrote:

@Prtksxna Someone pointed out that "Username" is the correct casing. I assume then that both Special:Block and Special:Investigate: should be updated to reflect this?

I was using the "Username" case for the labels, and the "UserName" case for placeholders because many on-wiki usernames are in PascalCase. If this is causing confusion anywhere then yep, we should change it. Could you share more context around where you got this feedback?

dom_walden moved this task from QA/Testing 🐞 to Design Review 🔬 on the Anti-Harassment-Team (The Letter Song) board.Apr 6 2021, 1:59 PM
dom_walden subscribed.

Special:Block on beta (with the correct Oxford Comma):

placeholder.png (761×284 px, 22 KB)

Test Environment: https://en.wikipedia.beta.wmflabs.org MediaWiki 1.36.0-alpha (494f154) 10:00, 6 April 2021.

In T263638#6975841, @Prtksxna wrote:
In T263638#6975831, @STran wrote:

@Prtksxna Someone pointed out that "Username" is the correct casing. I assume then that both Special:Block and Special:Investigate: should be updated to reflect this?

I was using the "Username" case for the labels, and the "UserName" case for placeholders because many on-wiki usernames are in PascalCase. If this is causing confusion anywhere then yep, we should change it. Could you share more context around where you got this feedback?

@Prtksxna I am guessing it is from code review. I am moving into Design Review, in case we want a decision on this. Otherwise, feel free to move along.

STran moved this task from Design Review 🔬 to Done: Q4 (2020-21) on the Anti-Harassment-Team (The Letter Song) board.Apr 8 2021, 3:35 PM
• Niharika closed this task as Resolved.Apr 13 2021, 3:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits