Page MenuHomePhabricator

Add placeholder text to Special:Block 'Username or IP address' field
Closed, ResolvedPublic1 Estimated Story Points

Description

Add placeholder text to Special:Block similar to that in Special:Investigate:

Screen Shot 2019-11-18 at 13.44.47.png (700ร—1 px, 64 KB)
image.png (366ร—1 px, 47 KB)
Special:InvestigateSpecial:Block

Note that the Special:Block field can also accept IP ranges.

Proposed placeholder text: UserName, 1.1.1.42 or 1.1.1.42/16

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptSep 23 2020, 1:26 PM
Niharika triaged this task as Medium priority.Mar 31 2021, 12:12 PM
Niharika updated the task description. (Show Details)

Change 676183 had a related patch set uploaded (by STran; author: STran):

[mediawiki/core@master] Update label and placeholder text for Special:Block target

https://gerrit.wikimedia.org/r/676183

Change 676183 merged by jenkins-bot:

[mediawiki/core@master] Update label and placeholder text for Special:Block target

https://gerrit.wikimedia.org/r/676183

@Prtksxna Someone pointed out that "Username" is the correct casing. I assume then that both Special:Block and Special:Investigate: should be updated to reflect this?

@Prtksxna Someone pointed out that "Username" is the correct casing. I assume then that both Special:Block and Special:Investigate: should be updated to reflect this?

I was using the "Username" case for the labels, and the "UserName" case for placeholders because many on-wiki usernames are in PascalCase. If this is causing confusion anywhere then yep, we should change it. Could you share more context around where you got this feedback?

dom_walden added a subscriber: dom_walden.

Special:Block on beta (with the correct Oxford Comma):

placeholder.png (284ร—761 px, 22 KB)

Test Environment: https://en.wikipedia.beta.wmflabs.org MediaWiki 1.36.0-alpha (494f154) 10:00, 6 April 2021.

@Prtksxna Someone pointed out that "Username" is the correct casing. I assume then that both Special:Block and Special:Investigate: should be updated to reflect this?

I was using the "Username" case for the labels, and the "UserName" case for placeholders because many on-wiki usernames are in PascalCase. If this is causing confusion anywhere then yep, we should change it. Could you share more context around where you got this feedback?

@Prtksxna I am guessing it is from code review. I am moving into Design Review, in case we want a decision on this. Otherwise, feel free to move along.