Page MenuHomePhabricator
Create Task
Maniphest T263642

TypeError when visiting Special:Unblock with no subpage
Closed, ResolvedPublic
Actions

Description

TypeError: Argument 1 passed to SpecialUnblock::getTargetAndType() must be of the type string, null given

#0 /srv/mediawiki/php-1.36.0-wmf.10/includes/specials/SpecialUnblock.php(51): SpecialUnblock->getTargetAndType(NULL, WebRequest)
#1 /srv/mediawiki/php-1.36.0-wmf.10/includes/specialpage/SpecialPage.php(600): SpecialUnblock->execute(NULL)
#2 /srv/mediawiki/php-1.36.0-wmf.10/includes/specialpage/SpecialPageFactory.php(692): SpecialPage->run(NULL)
#3 /srv/mediawiki/php-1.36.0-wmf.10/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#4 /srv/mediawiki/php-1.36.0-wmf.10/includes/MediaWiki.php(940): MediaWiki->performRequest()
#5 /srv/mediawiki/php-1.36.0-wmf.10/includes/MediaWiki.php(543): MediaWiki->main()
#6 /srv/mediawiki/php-1.36.0-wmf.10/index.php(53): MediaWiki->run()
#7 /srv/mediawiki/php-1.36.0-wmf.10/index.php(46): wfIndexMain()
#8 /srv/mediawiki/w/index.php(3): require(string)
#9 {main}

Currently on 1.36.0-wmf.10

Details

ProjectBranchLines +/-Subject
mediawiki/corewmf/1.36.0-wmf.10+4 -4SpecialUnblock: Allow getTargetAndType to accept null $par
mediawiki/coremaster+4 -4SpecialUnblock: Allow getTargetAndType to accept null $par
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Sep 23 2020, 1:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2020, 1:59 PM
Tchanders added a comment.Sep 23 2020, 2:02 PM

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/592250

gerritbot added a comment.Sep 23 2020, 2:02 PM

Change 629385 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] SpecialUnblock: Allow getTargetAndType to accept null $par

https://gerrit.wikimedia.org/r/629385

gerritbot added a project: Patch-For-Review.Sep 23 2020, 2:02 PM
Jdforrester-WMF triaged this task as Unbreak Now! priority.Sep 23 2020, 2:27 PM
Jdforrester-WMF added a parent task: T257978: 1.36.0-wmf.10 deployment blockers.
DannyS712 added a subscriber: DannyS712.Sep 23 2020, 2:32 PM
gerritbot added a comment.Sep 23 2020, 2:42 PM

Change 629390 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@wmf/1.36.0-wmf.10] SpecialUnblock: Allow getTargetAndType to accept null $par

https://gerrit.wikimedia.org/r/629390

gerritbot added a comment.Sep 23 2020, 2:53 PM

Change 629385 merged by jenkins-bot:
[mediawiki/core@master] SpecialUnblock: Allow getTargetAndType to accept null $par

https://gerrit.wikimedia.org/r/629385

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 23 2020, 3:00 PM
gerritbot added a comment.Sep 23 2020, 3:51 PM

Change 629390 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.10] SpecialUnblock: Allow getTargetAndType to accept null $par

https://gerrit.wikimedia.org/r/629390

Stashbot added a comment.Sep 23 2020, 3:56 PM

Mentioned in SAL (#wikimedia-operations) [2020-09-23T15:56:09Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.10/includes/specials/SpecialUnblock.php: rMW3234fad0d9b3: SpecialUnblock: Allow getTargetAndType to accept null $par (T263642) (duration: 01m 08s)

Stashbot added a comment.Sep 23 2020, 3:57 PM

Mentioned in SAL (#wikimedia-operations) [2020-09-23T15:57:29Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.10/includes/specials/SpecialBlock.php: rMW3234fad0d9b3: SpecialUnblock: Allow getTargetAndType to accept null $par (T263642) (duration: 01m 07s)

Urbanecm closed this task as Resolved.Sep 23 2020, 3:58 PM
Urbanecm assigned this task to Tchanders.
Urbanecm added a subscriber: Urbanecm.

https://test.wikipedia.org/wiki/Special:Unblock no longer throws anything.

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.10; 2020-09-22); removed MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 23 2020, 4:01 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 23 2020, 4:10 PM
dancy removed a parent task: T257978: 1.36.0-wmf.10 deployment blockers.Sep 23 2020, 11:30 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL