Page MenuHomePhabricator

Hook up keyboard shortcuts to the Pagelist Widget Dialog
Open, Needs TriagePublic

Description

Add some keyboard shortcuts to the Pagelist Widget Dialog.

Some ideas:

Key FeatureStatus
Left, Right (or Ctrl + Left, Ctrl + Right)Navigate the pagelist
Ctrl + Enter or EnterJump to next element in the form in the visual mode✅ Done by @Yash4357 (671932)
Ctrl + EnterUpdate the pagelist in wikitext modePatch to rebase (619511)

Event Timeline

Change 671932 had a related patch set uploaded (by Yash9265; owner: Yash9265):
[mediawiki/extensions/ProofreadPage@master] Hook up keyboard shortcuts to the Pagelist Widget Dialog

https://gerrit.wikimedia.org/r/671932

Change 671932 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Hook up keyboard shortcuts to the Pagelist Widget Dialog

https://gerrit.wikimedia.org/r/671932

@Soda, My setup part is complete now. Can I contribute in this field now ?

@Apoorv-Nsut Yeah, you can... Currently, all tasks are taken (have assignees)... I'll add some new ones soon.

Dereckson removed Yash4357 as the assignee of this task.
Dereckson added subscribers: Yash4357, Dereckson.

I've updated the description with a table with the current ideas and associated patches. Resetting assignee to mark we can contribute on that too (Yash, you can reassign yourself if you wish to go on on this task).

@Soda
I was looking this part of code to add the way to use arrow key to pass to one page further or backward,
but i don't undersand to find where the information of this object are

image.png (297×721 px, 15 KB)

can you help me ?

@DorianWinty That object should be in modules/index.pagelist/PagelistInputWidget.PagelistPreview.js which inherits from OO.ui.Widget. The general idea is to use selectItemByData() to select the next element.

@DorianWinty: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task, or do you need any help? Thanks!

hi, sorry
these time i'm realy bussy with school so i haven't work on it,
so if someone want to get et and work on it before i can came back he can

have a good day
thx to you too

Aklapper added a subscriber: DorianWinty.

I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. @DorianWinty: Please claim this task again when you plan to work on it (via Add Action...Assign / Claim in the dropdown menu) - it would be welcome. :) Thanks for your understanding!