Error
MediaWiki version: 1.36.0-wmf.9
NamespaceInfo::getAssociated does not make any sense for given namespace -9845
Impact
Unclear.
Notes
Just saw a batch of these show up in logs. Not persistent and not due to new MW software.
MediaWiki version: 1.36.0-wmf.9
NamespaceInfo::getAssociated does not make any sense for given namespace -9845
Unclear.
Just saw a batch of these show up in logs. Not persistent and not due to new MW software.
#0 /srv/mediawiki/php-1.36.0-wmf.9/includes/title/NamespaceInfo.php(301): NamespaceInfo->isMethodValidFor(integer, string) #1 /srv/mediawiki/php-1.36.0-wmf.9/includes/specials/pagers/NewPagesPager.php(160): NamespaceInfo->getAssociated(integer) #2 /srv/mediawiki/php-1.36.0-wmf.9/includes/specials/pagers/NewPagesPager.php(86): NewPagesPager->getNamespaceCond() #3 /srv/mediawiki/php-1.36.0-wmf.9/includes/pager/IndexPager.php(466): NewPagesPager->getQueryInfo() #4 /srv/mediawiki/php-1.36.0-wmf.9/includes/pager/IndexPager.php(447): IndexPager->buildQueryInfo(string, integer, boolean) #5 /srv/mediawiki/php-1.36.0-wmf.9/includes/pager/IndexPager.php(280): IndexPager->reallyDoQuery(string, integer, boolean) #6 /srv/mediawiki/php-1.36.0-wmf.9/includes/pager/IndexPager.php(733): IndexPager->doQuery() #7 /srv/mediawiki/php-1.36.0-wmf.9/includes/specials/SpecialNewpages.php(170): IndexPager->getNumRows() #8 /srv/mediawiki/php-1.36.0-wmf.9/includes/specialpage/SpecialPage.php(600): SpecialNewpages->execute(NULL) #9 /srv/mediawiki/php-1.36.0-wmf.9/includes/specialpage/SpecialPageFactory.php(680): SpecialPage->run(NULL) #10 /srv/mediawiki/php-1.36.0-wmf.9/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext) #11 /srv/mediawiki/php-1.36.0-wmf.9/includes/MediaWiki.php(940): MediaWiki->performRequest() #12 /srv/mediawiki/php-1.36.0-wmf.9/includes/MediaWiki.php(543): MediaWiki->main() #13 /srv/mediawiki/php-1.36.0-wmf.9/index.php(53): MediaWiki->run() #14 /srv/mediawiki/php-1.36.0-wmf.9/index.php(46): wfIndexMain() #15 /srv/mediawiki/w/index.php(3): require(string) #16 {main}
Project | Branch | Lines +/- | Subject | |
---|---|---|---|---|
mediawiki/core | REL1_35 | +5 -0 | NewPagesPager: Ignore nonexistent namespaces | |
mediawiki/core | master | +5 -0 | NewPagesPager: Ignore nonexistent namespaces |
@dancy its because someone was manually messing with their url I think. Percent decoding returns:
https://cs.wikipedia.org/wiki/Speciální:Nové_stránky?namespace=-9845 OR 2408=(SELECT UPPER(XMLType(CHR(60)||CHR(58)||CHR(113)||CHR(106)||CHR(120)||CHR(122)||CHR(113)||(SELECT (CASE WHEN (2408=2408) THEN 1 ELSE 0 END) FROM DUAL)||CHR(113)||CHR(106)||CHR(112)||CHR(107)||CHR(113)||CHR(62))) FROM DUAL)-- RFtw&invert=1&associated=1&tagfilter=SnzL&username=&size-mode=min&size=NqnN&wpFormIdentifier=newpagesform
which is unlikely to occur to a normal end user. Still should be fixed though.
This exception can be triggered deterministically at will by passing negative namespace number. The request parameters obviously need more sanity checks
Change 629393 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] NewPagesPager: Ignore nonexistent namespaces
Change 629393 merged by jenkins-bot:
[mediawiki/core@master] NewPagesPager: Ignore nonexistent namespaces
Change 629516 had a related patch set uploaded (by Reedy; owner: DannyS712):
[mediawiki/core@REL1_35] NewPagesPager: Ignore nonexistent namespaces
Change 629516 merged by jenkins-bot:
[mediawiki/core@REL1_35] NewPagesPager: Ignore nonexistent namespaces