Page MenuHomePhabricator
Create Task
Maniphest T263762

Make Kartographer extension compatible with Parsoid
Closed, ResolvedPublic
Actions

Assigned To
ihurbain
Authored By
ssastry
Sep 24 2020, 3:57 PM
Tags
Referenced Files
None
Subscribers
Aklapper
cscott
MSantos
ssastry

Description

Parsoid has its own extension API - see https://www.mediawiki.org/wiki/Parsoid/Extension_API.

The Kartographer extension needs an update to work directly with Parsoid so that we can switch Wikimedia wikis to use Parsoid instead of core parser in late 2021.

The Parsing Team will work with you as required.

Details

SubjectRepoBranchLines +/-
Decouple core parser from the MapLink/MapFrame implementationsmediawiki/extensions/Kartographermaster+51 -18
Extract processKartographerNode methodmediawiki/extensions/Kartographermaster+97 -83
Add extension data, categories and attribute processing to Parsoid outputmediawiki/extensions/Kartographermaster+175 -34
Add CSP header to Parsoid outputmediawiki/extensions/Kartographermaster+5 -2
Parsoid support for Kartographer version 1.0.0mediawiki/extensions/Kartographermaster+658 -18
Rework MapFrameAttributeGenerator test to not test private stuffmediawiki/extensions/Kartographermaster+6 -3
Extract image URL parameters into its own methodmediawiki/extensions/Kartographermaster+18 -7
Make constants in MapFrameAttributeGenerator private againmediawiki/extensions/Kartographermaster+29 -18
Fix extTag parser optionmediawiki/extensions/Kartographermaster+2 -2
Use page language rather than user languagemediawiki/extensions/Kartographermaster+24 -2
Minor adjustments pre-Parsoid patchmediawiki/extensions/Kartographermaster+107 -104
Mark more MapLinkAttributeGenerator properties as not nullablemediawiki/extensions/Kartographermaster+14 -13
Inline/rearrange parsing of geometries in LegacyTagHandlermediawiki/extensions/Kartographermaster+13 -28
Introduce small getContainerClasses helper methodmediawiki/extensions/Kartographermaster+13 -11
Add Parsoid-specific aliases to Phan configurationmediawiki/extensions/Kartographermaster+45 -0
Inline all $static… MapFrameAttributeGenerator propertiesmediawiki/extensions/Kartographermaster+27 -42
Move some MapFrameAttributeGenerator code to more local placesmediawiki/extensions/Kartographermaster+20 -22
Introduce ParsoidWikitextParsermediawiki/extensions/Kartographermaster+51 -13
Add a Parsoid skeletonmediawiki/extensions/Kartographermaster+229 -18
Introduce MapFrameAttributeGeneratormediawiki/extensions/Kartographermaster+212 -129
Replace MapLinkTrait by MapLinkAttributeGeneratormediawiki/extensions/Kartographermaster+103 -100
Export internationalized fragment creation to ParsoidUtils classmediawiki/extensions/Kartographermaster+34 -8
Make updateMarkerSymbolCounters data update optionalmediawiki/extensions/Kartographermaster+92 -0
Skip parsing empty and auto-generated maplink labelsmediawiki/extensions/Kartographermaster+2 -1
Use tiny PartialWikitextParser service instead of full Parsermediawiki/extensions/Kartographermaster+45 -10
Avoid some bits of code duplication in CoordFormattermediawiki/extensions/Kartographermaster+23 -33
Make CoordFormatter compatible with Parsoidmediawiki/extensions/Kartographermaster+123 -46
Bump parsoid to 0.17.0-a17mediawiki/vendormaster+1 K -795
Add methods to enable "arbitrary language" for i18nmediawiki/services/parsoidmaster+122 -2
Remove knowledge about specific tag names from State classmediawiki/extensions/Kartographermaster+51 -64
Add strict types to properties and parameters where possiblemediawiki/extensions/Kartographermaster+77 -77
Rename confusing getText to getStringmediawiki/extensions/Kartographermaster+12 -12
Extract common data from tags to their own classmediawiki/extensions/Kartographermaster+450 -342
[WIP] Refactor tags to extract the parser-specific logicmediawiki/extensions/Kartographermaster+1 K -726
Extract argument parsing into small, neutral servicemediawiki/extensions/Kartographermaster+297 -232
Make getText/Int/Float return null instead of useless `false`mediawiki/extensions/Kartographermaster+22 -23
Rename tag handlers to "legacy" tag handlersmediawiki/extensions/Kartographermaster+16 -16
Decouple addModules/getTargetLanguage from the legacy Parsermediawiki/extensions/Kartographermaster+19 -10
Pass $isPreview as parameter to TagHandler::render()mediawiki/extensions/Kartographermaster+8 -7
Decouple code a bit better from actual Language objectsmediawiki/extensions/Kartographermaster+24 -10
MapLink: move shared logic to traitmediawiki/extensions/Kartographermaster+96 -50
Decouple parser logic from SimpleStyleParsermediawiki/extensions/Kartographermaster+333 -316
Extract wikitext parser calls to a small servicemediawiki/extensions/Kartographermaster+64 -29
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Jan 30 2023, 2:01 PM

Change 884885 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Rename tag handlers to "legacy" tag handlers

https://gerrit.wikimedia.org/r/884885

gerritbot added a comment.Jan 30 2023, 3:30 PM

Change 884917 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Adding some strict types

https://gerrit.wikimedia.org/r/884917

ihurbain claimed this task.Jan 30 2023, 3:34 PM
ihurbain added a project: Content-Transform-Team-WIP.
ihurbain moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.
gerritbot added a comment.Jan 30 2023, 4:37 PM

Change 884958 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Make getText/Int/Float return null instead of useless `false`

https://gerrit.wikimedia.org/r/884958

gerritbot added a comment.Jan 30 2023, 11:37 PM

Change 884958 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Make getText/Int/Float return null instead of useless `false`

https://gerrit.wikimedia.org/r/884958

gerritbot added a comment.Feb 3 2023, 11:05 AM

Change 886339 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Skip parsing empty and auto-generated maplink labels

https://gerrit.wikimedia.org/r/886339

gerritbot added a comment.Feb 3 2023, 5:43 PM

Change 886394 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Extract common data from tags to their own class

https://gerrit.wikimedia.org/r/886394

• JMcLeod_WMF raised the priority of this task from Low to High.Feb 6 2023, 4:25 PM
gerritbot added a comment.Feb 7 2023, 11:24 AM

Change 880975 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Extract argument parsing into small, neutral service

https://gerrit.wikimedia.org/r/880975

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.23; 2023-02-13); removed MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Feb 7 2023, 12:00 PM
gerritbot added a comment.Feb 7 2023, 8:22 PM

Change 887396 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Rename confusing getText to getString

https://gerrit.wikimedia.org/r/887396

awight added a project: WMDE-TechWish-Sprint-2023-01-18.Feb 8 2023, 7:12 AM
awight moved this task from Sprint Backlog to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2023-01-18 board.
gerritbot added a comment.Feb 9 2023, 9:37 AM

Change 883862 abandoned by Isabelle Hurbain-Palatin:

[mediawiki/extensions/Kartographer@master] [WIP] Refactor tags to extract the parser-specific logic

Reason:

Abandoned in favor of 880975 and other following patches.

https://gerrit.wikimedia.org/r/883862

gerritbot added a comment.Feb 9 2023, 9:40 AM

Change 886394 abandoned by Isabelle Hurbain-Palatin:

[mediawiki/extensions/Kartographer@master] Extract common data from tags to their own class

Reason:

Abandoned in favor of 880975 and other following patches.

https://gerrit.wikimedia.org/r/886394

gerritbot added a comment.Feb 9 2023, 9:47 AM

Change 887396 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Rename confusing getText to getString

https://gerrit.wikimedia.org/r/887396

gerritbot added a comment.Feb 10 2023, 10:42 AM

Change 884917 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Add strict types to properties and parameters where possible

https://gerrit.wikimedia.org/r/884917

gerritbot added a comment.Feb 13 2023, 12:40 PM

Change 888684 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Add methods to enable "arbitrary language" for i18n

https://gerrit.wikimedia.org/r/888684

gerritbot added a comment.Feb 14 2023, 5:41 PM

Change 889184 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Make CoordFormatter compatible with Parsoid

https://gerrit.wikimedia.org/r/889184

gerritbot added a comment.Feb 16 2023, 1:41 PM

Change 880974 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Remove knowledge about specific tag names from State class

https://gerrit.wikimedia.org/r/880974

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.24; 2023-02-20); removed MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 16 2023, 2:00 PM
gerritbot added a comment.Feb 17 2023, 3:04 PM

Change 888684 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add methods to enable "arbitrary language" for i18n

https://gerrit.wikimedia.org/r/888684

gerritbot added a comment.Feb 20 2023, 6:29 PM

Change 890498 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a17

https://gerrit.wikimedia.org/r/890498

gerritbot added a comment.Feb 20 2023, 6:51 PM

Change 890498 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a17

https://gerrit.wikimedia.org/r/890498

gerritbot added a comment.Feb 22 2023, 5:09 PM

Change 891334 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Avoid some bits of code duplication in CoordFormatter

https://gerrit.wikimedia.org/r/891334

gerritbot added a comment.Feb 23 2023, 12:28 PM

Change 889184 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Make CoordFormatter compatible with Parsoid

https://gerrit.wikimedia.org/r/889184

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.25; 2023-02-27); removed MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 23 2023, 2:00 PM
gerritbot added a comment.Feb 23 2023, 4:21 PM

Change 891334 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Avoid some bits of code duplication in CoordFormatter

https://gerrit.wikimedia.org/r/891334

gerritbot added a comment.Feb 28 2023, 5:10 PM

Change 881003 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Use tiny PartialWikitextParser service instead of full Parser

https://gerrit.wikimedia.org/r/881003

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.26; 2023-03-06); removed MW-1.40-notes (1.40.0-wmf.25; 2023-02-27).Feb 28 2023, 6:00 PM
gerritbot added a comment.Mar 1 2023, 8:04 AM

Change 886339 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Skip parsing empty and auto-generated maplink labels

https://gerrit.wikimedia.org/r/886339

gerritbot added a comment.Mar 16 2023, 5:14 PM

Change 900387 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Make updateMarkerSymbolCounters data update optional

https://gerrit.wikimedia.org/r/900387

gerritbot added a comment.Mar 16 2023, 5:37 PM

Change 900402 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Export internationalized fragment creation to ParsoidUtils class

https://gerrit.wikimedia.org/r/900402

gerritbot added a comment.Mar 20 2023, 12:48 PM

Change 901143 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Replace MapLinkTrait by MapLinkAttributeGenerator

https://gerrit.wikimedia.org/r/901143

gerritbot added a comment.Mar 21 2023, 6:16 PM

Change 901252 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Introduce MapFrameAttributeGenerator

https://gerrit.wikimedia.org/r/901252

gerritbot added a comment.Mar 21 2023, 6:31 PM

Change 900387 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Make updateMarkerSymbolCounters data update optional

https://gerrit.wikimedia.org/r/900387

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 21 2023, 7:00 PM
gerritbot added a comment.Mar 27 2023, 10:52 AM

Change 900402 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Export internationalized fragment creation to ParsoidUtils class

https://gerrit.wikimedia.org/r/900402

gerritbot added a comment.Mar 27 2023, 10:52 AM

Change 901143 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Replace MapLinkTrait by MapLinkAttributeGenerator

https://gerrit.wikimedia.org/r/901143

gerritbot added a comment.Mar 27 2023, 5:24 PM

Change 903312 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Add a Parsoid skeleton

https://gerrit.wikimedia.org/r/903312

gerritbot added a comment.Mar 30 2023, 10:14 AM

Change 904491 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Introduce ParsoidWikitextParser

https://gerrit.wikimedia.org/r/904491

gerritbot added a comment.Mar 30 2023, 2:55 PM

Change 904554 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Move some MapFrameAttributeGenerator code to more local places

https://gerrit.wikimedia.org/r/904554

gerritbot added a comment.Mar 30 2023, 3:40 PM

Change 904566 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Inline all $static… MapFrameAttributeGenerator properties

https://gerrit.wikimedia.org/r/904566

gerritbot added a comment.Mar 30 2023, 3:46 PM

Change 904568 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Introduce small getContainerClasses helper method

https://gerrit.wikimedia.org/r/904568

gerritbot added a comment.Mar 30 2023, 4:19 PM

Change 901252 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Introduce MapFrameAttributeGenerator

https://gerrit.wikimedia.org/r/901252

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.3; 2023-04-03); removed MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 30 2023, 5:00 PM
gerritbot added a comment.Mar 30 2023, 5:27 PM

Change 903312 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Add a Parsoid skeleton

https://gerrit.wikimedia.org/r/903312

gerritbot added a comment.Mar 31 2023, 6:51 AM

Change 904491 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Introduce ParsoidWikitextParser

https://gerrit.wikimedia.org/r/904491

gerritbot added a comment.Mar 31 2023, 9:36 AM

Change 904554 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Move some MapFrameAttributeGenerator code to more local places

https://gerrit.wikimedia.org/r/904554

gerritbot added a comment.Mar 31 2023, 4:13 PM

Change 904566 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Inline all $static… MapFrameAttributeGenerator properties

https://gerrit.wikimedia.org/r/904566

gerritbot added a comment.Apr 3 2023, 11:33 AM

Change 905199 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Move $geometries in the MapTagArgumentValidator

https://gerrit.wikimedia.org/r/905199

gerritbot added a comment.Apr 4 2023, 8:20 AM

Change 905566 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Add Parsoid-specific aliases to Phan configuration

https://gerrit.wikimedia.org/r/905566

gerritbot added a comment.Apr 4 2023, 8:45 AM

Change 905566 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Add Parsoid-specific aliases to Phan configuration

https://gerrit.wikimedia.org/r/905566

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.4; 2023-04-10); removed MW-1.41-notes (1.41.0-wmf.3; 2023-04-03).Apr 4 2023, 9:00 AM
gerritbot added a comment.Apr 4 2023, 9:21 AM

Change 904568 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Introduce small getContainerClasses helper method

https://gerrit.wikimedia.org/r/904568

MSantos added a project: Parsoid-Read-Views (Phase 1 - DiscussionTools support).Apr 10 2023, 3:54 PM
Restricted Application edited projects, added Parsoid; removed Parsoid (Tracking). · View Herald TranscriptApr 10 2023, 3:54 PM
MSantos moved this task from Backlog to In Progress on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.Apr 10 2023, 3:54 PM
gerritbot added a comment.Apr 11 2023, 6:05 PM

Change 905199 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Inline/rearrange parsing of geometries in LegacyTagHandler

https://gerrit.wikimedia.org/r/905199

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.5; 2023-04-17); removed MW-1.41-notes (1.41.0-wmf.4; 2023-04-10).Apr 11 2023, 7:00 PM
gerritbot added a comment.Apr 14 2023, 4:55 PM

Change 905689 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] [WIP] [DNM] parsoid compat

https://gerrit.wikimedia.org/r/905689

MSantos added a subtask: T139694: Kartographer's Wikivoyage mode relies on global state (which isn't allowed), so listing numbers are all "1" at all Wikivoyages in VE mode and other issues.May 8 2023, 6:45 AM
gerritbot added a comment.May 25 2023, 9:24 AM

Change 923286 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Use page language rather than user language

https://gerrit.wikimedia.org/r/923286

gerritbot added a comment.May 25 2023, 9:24 AM

Change 923287 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Minor adjustments pre-Parsoid patch

https://gerrit.wikimedia.org/r/923287

gerritbot added a comment.May 25 2023, 9:24 AM

Change 923288 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Fix extTag parser option

https://gerrit.wikimedia.org/r/923288

ihurbain moved this task from In Progress to Code Review on the Content-Transform-Team-WIP board.May 25 2023, 1:10 PM
gerritbot added a comment.May 25 2023, 1:25 PM

Change 923340 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Make constants in MapFrameAttributeGenerator private again

https://gerrit.wikimedia.org/r/923340

gerritbot added a comment.May 25 2023, 1:57 PM

Change 923347 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Mark more MapLinkAttributeGenerator properties as not nullable

https://gerrit.wikimedia.org/r/923347

ihurbain closed subtask T331652: Fix data-mw='interface' usage in Kartographer as Resolved.May 30 2023, 8:05 AM
gerritbot added a comment.Jun 1 2023, 11:14 AM

Change 923347 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Mark more MapLinkAttributeGenerator properties as not nullable

https://gerrit.wikimedia.org/r/923347

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.12; 2023-06-06); removed MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Jun 1 2023, 1:00 PM
thiemowmde mentioned this in T338118: Write pure unit tests for all Kartographer service classes.Jun 5 2023, 7:53 AM
gerritbot added a comment.Jun 15 2023, 7:53 PM

Change 923286 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Use page language rather than user language

https://gerrit.wikimedia.org/r/923286

gerritbot added a comment.Jun 15 2023, 7:53 PM

Change 923287 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Minor adjustments pre-Parsoid patch

https://gerrit.wikimedia.org/r/923287

gerritbot added a comment.Jun 15 2023, 7:53 PM

Change 923288 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Fix extTag parser option

https://gerrit.wikimedia.org/r/923288

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.15; 2023-06-27); removed MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 15 2023, 8:00 PM
gerritbot added a comment.Jun 19 2023, 9:08 AM

Change 923340 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Make constants in MapFrameAttributeGenerator private again

https://gerrit.wikimedia.org/r/923340

gerritbot added a comment.Jun 22 2023, 11:50 AM

Change 932221 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Extract image URL parameters into its own method

https://gerrit.wikimedia.org/r/932221

gerritbot added a comment.Jun 22 2023, 12:48 PM

Change 932235 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Add a feature flag for Parsoid support deployment

https://gerrit.wikimedia.org/r/932235

gerritbot added a comment.Jun 22 2023, 1:54 PM

Change 932249 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Rework MapFrameAttributeGenerator test to not test private stuff

https://gerrit.wikimedia.org/r/932249

gerritbot added a comment.Jun 22 2023, 4:04 PM

Change 932221 merged by Isabelle Hurbain-Palatin:

[mediawiki/extensions/Kartographer@master] Extract image URL parameters into its own method

https://gerrit.wikimedia.org/r/932221

gerritbot added a comment.Jun 22 2023, 4:10 PM

Change 932249 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Rework MapFrameAttributeGenerator test to not test private stuff

https://gerrit.wikimedia.org/r/932249

gerritbot added a comment.Jul 7 2023, 3:04 PM

Change 936292 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Add extension data and categories to Parsoid output

https://gerrit.wikimedia.org/r/936292

gerritbot added a comment.Jul 17 2023, 3:48 PM

Change 938883 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Extract processKartographerNode method

https://gerrit.wikimedia.org/r/938883

gerritbot added a comment.Jul 17 2023, 5:46 PM

Change 905689 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Parsoid support for Kartographer version 1.0.0

https://gerrit.wikimedia.org/r/905689

gerritbot added a comment.Jul 18 2023, 4:55 PM

Change 939351 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] [WIP] maplink in attribute support

https://gerrit.wikimedia.org/r/939351

gerritbot added a comment.Jul 25 2023, 12:00 PM

Change 941389 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Add CSP header to Parsoid output

https://gerrit.wikimedia.org/r/941389

gerritbot added a comment.Aug 4 2023, 3:20 PM

Change 941389 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Add CSP header to Parsoid output

https://gerrit.wikimedia.org/r/941389

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Aug 4 2023, 4:00 PM
gerritbot added a comment.Aug 29 2023, 5:54 PM

Change 936292 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Add extension data, categories and attribute processing to Parsoid output

https://gerrit.wikimedia.org/r/936292

gerritbot added a comment.Aug 29 2023, 5:54 PM

Change 938883 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Extract processKartographerNode method

https://gerrit.wikimedia.org/r/938883

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 30 2023, 6:00 AM
MSantos lowered the priority of this task from High to Medium.Sep 19 2023, 4:05 PM
ihurbain closed subtask T139694: Kartographer's Wikivoyage mode relies on global state (which isn't allowed), so listing numbers are all "1" at all Wikivoyages in VE mode and other issues as Resolved.Oct 31 2023, 1:50 PM
ihurbain closed this task as Resolved.Oct 31 2023, 1:54 PM

Kartographer has been deployed on enwiki, enwikibooks, enwikinews, enwikiquote, enwikisource, enwikiversity, enwikivoyage and enwiktionary. This issue can be closed; further deployments will be tracked by T342871 once T342876 is resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL