Page MenuHomePhabricator

ChangeVisibilityNotificationJobTest test failures
Closed, ResolvedPublic

Description

Wikibase tests fail due to the changes in T260485

[20:07:44] <legoktm> Reedy: unless you already have a fix, I'd suggest just disabling the Wikibase tests, it looks like they're trying to use fake users without creating them, and ActorMigration gets all confused by that now

https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/36808/console

19:43:01 There were 6 errors:
19:43:01 
19:43:01 1) Wikibase\Client\Tests\Integration\ChangeModification\ChangeVisibilityNotificationJobTest::testRun with data set "redact nothing" (array(), array(Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...)), 6)
19:43:01 CannotCreateActorException: Failed to create actor ID for user_id=23 user_name="Test"
19:43:01 
19:43:01 /workspace/src/includes/ActorMigration.php:312
19:43:01 /workspace/src/includes/ActorMigration.php:351
19:43:01 /workspace/src/includes/changes/RecentChange.php:389
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/RecentChangesModificationTest.php:213
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/ChangeVisibilityNotificationJobTest.php:34
19:43:01 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
19:43:01 /workspace/src/maintenance/doMaintenance.php:107
19:43:01 === Logs generated by test case
19:43:01 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
19:43:01 ===
19:43:01 
19:43:01 2) Wikibase\Client\Tests\Integration\ChangeModification\ChangeVisibilityNotificationJobTest::testRun with data set "redact one entry with one RepoRevisionIdentifier" (array('UNIQ-001'), array(Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...)), 6)
19:43:01 CannotCreateActorException: Failed to create actor ID for user_id=23 user_name="Test"
19:43:01 
19:43:01 /workspace/src/includes/ActorMigration.php:312
19:43:01 /workspace/src/includes/ActorMigration.php:351
19:43:01 /workspace/src/includes/changes/RecentChange.php:389
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/RecentChangesModificationTest.php:213
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/ChangeVisibilityNotificationJobTest.php:34
19:43:01 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
19:43:01 /workspace/src/maintenance/doMaintenance.php:107
19:43:01 === Logs generated by test case
19:43:01 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
19:43:01 ===
19:43:01 
19:43:01 3) Wikibase\Client\Tests\Integration\ChangeModification\ChangeVisibilityNotificationJobTest::testRun with data set "redact one entry with two RepoRevisionIdentifiers" (array('UNIQ-001'), array(Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...), Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...)), 6)
19:43:01 CannotCreateActorException: Failed to create actor ID for user_id=23 user_name="Test"
19:43:01 
19:43:01 /workspace/src/includes/ActorMigration.php:312
19:43:01 /workspace/src/includes/ActorMigration.php:351
19:43:01 /workspace/src/includes/changes/RecentChange.php:389
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/RecentChangesModificationTest.php:213
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/ChangeVisibilityNotificationJobTest.php:34
19:43:01 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
19:43:01 /workspace/src/maintenance/doMaintenance.php:107
19:43:01 === Logs generated by test case
19:43:01 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
19:43:01 ===
19:43:01 
19:43:01 4) Wikibase\Client\Tests\Integration\ChangeModification\ChangeVisibilityNotificationJobTest::testRun with data set "redact two entries with one RepoRevisionIdentifier" (array('UNIQ-005', 'UNIQ-006'), array(Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...)), 12)
19:43:01 CannotCreateActorException: Failed to create actor ID for user_id=23 user_name="Test"
19:43:01 
19:43:01 /workspace/src/includes/ActorMigration.php:312
19:43:01 /workspace/src/includes/ActorMigration.php:351
19:43:01 /workspace/src/includes/changes/RecentChange.php:389
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/RecentChangesModificationTest.php:213
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/ChangeVisibilityNotificationJobTest.php:34
19:43:01 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
19:43:01 /workspace/src/maintenance/doMaintenance.php:107
19:43:01 === Logs generated by test case
19:43:01 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
19:43:01 ===
19:43:01 
19:43:01 5) Wikibase\Client\Tests\Integration\ChangeModification\ChangeVisibilityNotificationJobTest::testRun with data set "redact multiple entries with multiple RepoRevisionIdentifiers" (array('UNIQ-001', 'UNIQ-005', 'UNIQ-006'), array(Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...), Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...), Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...)), 4)
19:43:01 CannotCreateActorException: Failed to create actor ID for user_id=23 user_name="Test"
19:43:01 
19:43:01 /workspace/src/includes/ActorMigration.php:312
19:43:01 /workspace/src/includes/ActorMigration.php:351
19:43:01 /workspace/src/includes/changes/RecentChange.php:389
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/RecentChangesModificationTest.php:213
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/ChangeVisibilityNotificationJobTest.php:34
19:43:01 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
19:43:01 /workspace/src/maintenance/doMaintenance.php:107
19:43:01 === Logs generated by test case
19:43:01 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
19:43:01 ===
19:43:01 
19:43:01 6) Wikibase\Client\Tests\Integration\ChangeModification\ChangeVisibilityNotificationJobTest::testRun_recentChangeFactoryRoundtrip
19:43:01 CannotCreateActorException: Failed to create actor ID for user_id=23 user_name="Test"
19:43:01 
19:43:01 /workspace/src/includes/ActorMigration.php:312
19:43:01 /workspace/src/includes/ActorMigration.php:351
19:43:01 /workspace/src/includes/changes/RecentChange.php:389
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/RecentChangesModificationTest.php:213
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/ChangeVisibilityNotificationJobTest.php:51
19:43:01 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
19:43:01 /workspace/src/maintenance/doMaintenance.php:107
19:43:01 === Logs generated by test case
19:43:01 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}

Going to disable these broken tests, tag it against this task, and then leave it open for fixing/refactoring/whatever else

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 629798 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Wikibase@master] Mark ChangeVisibilityNotificationJobTest::testRun() as skipped

https://gerrit.wikimedia.org/r/629798

Change 629798 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Mark ChangeVisibilityNotificationJobTest::testRun() as skipped

https://gerrit.wikimedia.org/r/629798

Change 629769 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] RecentChangesModificationTest: Use actor table

https://gerrit.wikimedia.org/r/629769

Change 629804 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Wikibase@master] Mark ChangeVisibilityNotificationJobTest::testRun_recentChangeFactoryRoundtrip() as skipped

https://gerrit.wikimedia.org/r/629804

Change 629804 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Mark ChangeVisibilityNotificationJobTest::testRun_recentChangeFactoryRoundtrip() as skipped

https://gerrit.wikimedia.org/r/629804

Change 629819 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Wikibase@master] Mark more tests as skipped due to actor issues

https://gerrit.wikimedia.org/r/629819

Change 629819 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Mark more tests as skipped due to actor issues

https://gerrit.wikimedia.org/r/629819

Are the relevant ActorMigration changes all published and merged? Because locally, on latest MediaWiki core and Wikibase, if I remove the markTestSkipped lines the tests seem to work.

Change 630781 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Reenable disabled ChangeVisibilityNotificationJobTest tests

https://gerrit.wikimedia.org/r/630781

Note there’s 3 PS to revert

And yeah, the master changes have been merged

Thanks, updated my change to remove the other skips too.

Change 630814 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use proper test users in Client tests

https://gerrit.wikimedia.org/r/630814

Pulling this into the campsite to reenable the tests as soon as possible.

Change 630814 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use proper test users in Client tests

https://gerrit.wikimedia.org/r/630814

Change 630781 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Reenable tests disabled due to actor migration issues

https://gerrit.wikimedia.org/r/630781

Change 630794 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@REL1_35] Use proper test users in Client tests

https://gerrit.wikimedia.org/r/630794

I think we can close this, there aren’t any more search results for T263785 in the code.

Change 630794 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@REL1_35] Use proper test users in Client tests

https://gerrit.wikimedia.org/r/630794