Page MenuHomePhabricator
Create Task
Maniphest T263785

ChangeVisibilityNotificationJobTest test failures
Closed, ResolvedPublic
Actions

Description

Wikibase tests fail due to the changes in T260485

[20:07:44] <legoktm> Reedy: unless you already have a fix, I'd suggest just disabling the Wikibase tests, it looks like they're trying to use fake users without creating them, and ActorMigration gets all confused by that now

https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/36808/console

19:43:01 There were 6 errors:
19:43:01 
19:43:01 1) Wikibase\Client\Tests\Integration\ChangeModification\ChangeVisibilityNotificationJobTest::testRun with data set "redact nothing" (array(), array(Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...)), 6)
19:43:01 CannotCreateActorException: Failed to create actor ID for user_id=23 user_name="Test"
19:43:01 
19:43:01 /workspace/src/includes/ActorMigration.php:312
19:43:01 /workspace/src/includes/ActorMigration.php:351
19:43:01 /workspace/src/includes/changes/RecentChange.php:389
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/RecentChangesModificationTest.php:213
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/ChangeVisibilityNotificationJobTest.php:34
19:43:01 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
19:43:01 /workspace/src/maintenance/doMaintenance.php:107
19:43:01 === Logs generated by test case
19:43:01 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
19:43:01 ===
19:43:01 
19:43:01 2) Wikibase\Client\Tests\Integration\ChangeModification\ChangeVisibilityNotificationJobTest::testRun with data set "redact one entry with one RepoRevisionIdentifier" (array('UNIQ-001'), array(Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...)), 6)
19:43:01 CannotCreateActorException: Failed to create actor ID for user_id=23 user_name="Test"
19:43:01 
19:43:01 /workspace/src/includes/ActorMigration.php:312
19:43:01 /workspace/src/includes/ActorMigration.php:351
19:43:01 /workspace/src/includes/changes/RecentChange.php:389
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/RecentChangesModificationTest.php:213
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/ChangeVisibilityNotificationJobTest.php:34
19:43:01 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
19:43:01 /workspace/src/maintenance/doMaintenance.php:107
19:43:01 === Logs generated by test case
19:43:01 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
19:43:01 ===
19:43:01 
19:43:01 3) Wikibase\Client\Tests\Integration\ChangeModification\ChangeVisibilityNotificationJobTest::testRun with data set "redact one entry with two RepoRevisionIdentifiers" (array('UNIQ-001'), array(Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...), Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...)), 6)
19:43:01 CannotCreateActorException: Failed to create actor ID for user_id=23 user_name="Test"
19:43:01 
19:43:01 /workspace/src/includes/ActorMigration.php:312
19:43:01 /workspace/src/includes/ActorMigration.php:351
19:43:01 /workspace/src/includes/changes/RecentChange.php:389
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/RecentChangesModificationTest.php:213
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/ChangeVisibilityNotificationJobTest.php:34
19:43:01 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
19:43:01 /workspace/src/maintenance/doMaintenance.php:107
19:43:01 === Logs generated by test case
19:43:01 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
19:43:01 ===
19:43:01 
19:43:01 4) Wikibase\Client\Tests\Integration\ChangeModification\ChangeVisibilityNotificationJobTest::testRun with data set "redact two entries with one RepoRevisionIdentifier" (array('UNIQ-005', 'UNIQ-006'), array(Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...)), 12)
19:43:01 CannotCreateActorException: Failed to create actor ID for user_id=23 user_name="Test"
19:43:01 
19:43:01 /workspace/src/includes/ActorMigration.php:312
19:43:01 /workspace/src/includes/ActorMigration.php:351
19:43:01 /workspace/src/includes/changes/RecentChange.php:389
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/RecentChangesModificationTest.php:213
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/ChangeVisibilityNotificationJobTest.php:34
19:43:01 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
19:43:01 /workspace/src/maintenance/doMaintenance.php:107
19:43:01 === Logs generated by test case
19:43:01 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
19:43:01 ===
19:43:01 
19:43:01 5) Wikibase\Client\Tests\Integration\ChangeModification\ChangeVisibilityNotificationJobTest::testRun with data set "redact multiple entries with multiple RepoRevisionIdentifiers" (array('UNIQ-001', 'UNIQ-005', 'UNIQ-006'), array(Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...), Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...), Wikibase\Lib\Changes\RepoRevisionIdentifier Object (...)), 4)
19:43:01 CannotCreateActorException: Failed to create actor ID for user_id=23 user_name="Test"
19:43:01 
19:43:01 /workspace/src/includes/ActorMigration.php:312
19:43:01 /workspace/src/includes/ActorMigration.php:351
19:43:01 /workspace/src/includes/changes/RecentChange.php:389
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/RecentChangesModificationTest.php:213
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/ChangeVisibilityNotificationJobTest.php:34
19:43:01 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
19:43:01 /workspace/src/maintenance/doMaintenance.php:107
19:43:01 === Logs generated by test case
19:43:01 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
19:43:01 ===
19:43:01 
19:43:01 6) Wikibase\Client\Tests\Integration\ChangeModification\ChangeVisibilityNotificationJobTest::testRun_recentChangeFactoryRoundtrip
19:43:01 CannotCreateActorException: Failed to create actor ID for user_id=23 user_name="Test"
19:43:01 
19:43:01 /workspace/src/includes/ActorMigration.php:312
19:43:01 /workspace/src/includes/ActorMigration.php:351
19:43:01 /workspace/src/includes/changes/RecentChange.php:389
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/RecentChangesModificationTest.php:213
19:43:01 /workspace/src/extensions/Wikibase/client/tests/phpunit/integration/includes/ChangeModification/ChangeVisibilityNotificationJobTest.php:51
19:43:01 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
19:43:01 /workspace/src/maintenance/doMaintenance.php:107
19:43:01 === Logs generated by test case
19:43:01 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}

Going to disable these broken tests, tag it against this task, and then leave it open for fixing/refactoring/whatever else

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use proper test users in Client testsmediawiki/extensions/WikibaseREL1_35+11 -34
Reenable tests disabled due to actor migration issuesmediawiki/extensions/Wikibasemaster+0 -4
Use proper test users in Client testsmediawiki/extensions/Wikibasemaster+11 -22
Mark more tests as skipped due to actor issuesmediawiki/extensions/Wikibasemaster+2 -0
Mark ChangeVisibilityNotificationJobTest::testRun_recentChangeFactoryRoundtrip() as skippedmediawiki/extensions/Wikibasemaster+1 -0
Mark ChangeVisibilityNotificationJobTest::testRun() as skippedmediawiki/extensions/Wikibasemaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Sep 24 2020, 7:09 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptSep 24 2020, 7:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Sep 24 2020, 7:12 PM

Change 629798 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Wikibase@master] Mark ChangeVisibilityNotificationJobTest::testRun() as skipped

https://gerrit.wikimedia.org/r/629798

gerritbot added a project: Patch-For-Review.Sep 24 2020, 7:12 PM
gerritbot added a comment.Sep 24 2020, 7:37 PM

Change 629798 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Mark ChangeVisibilityNotificationJobTest::testRun() as skipped

https://gerrit.wikimedia.org/r/629798

gerritbot added a comment.Sep 24 2020, 7:43 PM

Change 629769 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] RecentChangesModificationTest: Use actor table

https://gerrit.wikimedia.org/r/629769

gerritbot added a comment.Sep 24 2020, 7:50 PM

Change 629804 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Wikibase@master] Mark ChangeVisibilityNotificationJobTest::testRun_recentChangeFactoryRoundtrip() as skipped

https://gerrit.wikimedia.org/r/629804

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 24 2020, 8:00 PM
gerritbot added a comment.Sep 24 2020, 8:14 PM

Change 629804 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Mark ChangeVisibilityNotificationJobTest::testRun_recentChangeFactoryRoundtrip() as skipped

https://gerrit.wikimedia.org/r/629804

gerritbot added a comment.Sep 24 2020, 8:42 PM

Change 629819 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Wikibase@master] Mark more tests as skipped due to actor issues

https://gerrit.wikimedia.org/r/629819

gerritbot added a comment.Sep 24 2020, 9:06 PM

Change 629819 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Mark more tests as skipped due to actor issues

https://gerrit.wikimedia.org/r/629819

DannyS712 subscribed.Sep 24 2020, 11:26 PM
WMDE-leszek subscribed.Sep 29 2020, 5:49 AM
Michael subscribed.Sep 29 2020, 9:04 AM
Lucas_Werkmeister_WMDE subscribed.Sep 29 2020, 9:35 AM
Lucas_Werkmeister_WMDE added a comment.Sep 29 2020, 10:27 AM

Are the relevant ActorMigration changes all published and merged? Because locally, on latest MediaWiki core and Wikibase, if I remove the markTestSkipped lines the tests seem to work.

gerritbot added a comment.Sep 29 2020, 10:31 AM

Change 630781 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Reenable disabled ChangeVisibilityNotificationJobTest tests

https://gerrit.wikimedia.org/r/630781

Reedy added a comment.Sep 29 2020, 10:37 AM

Note there’s 3 PS to revert

And yeah, the master changes have been merged

Lucas_Werkmeister_WMDE added a comment.Sep 29 2020, 10:41 AM

Thanks, updated my change to remove the other skips too.

gerritbot added a comment.Sep 29 2020, 12:12 PM

Change 630814 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use proper test users in Client tests

https://gerrit.wikimedia.org/r/630814

Lucas_Werkmeister_WMDE claimed this task.Sep 29 2020, 2:31 PM
Lucas_Werkmeister_WMDE added a subscriber: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).

Pulling this into the campsite to reenable the tests as soon as possible.

Lucas_Werkmeister_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Sep 29 2020, 2:31 PM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE removed a subscriber: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
gerritbot added a comment.Sep 29 2020, 3:03 PM

Change 630814 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use proper test users in Client tests

https://gerrit.wikimedia.org/r/630814

gerritbot added a comment.Sep 29 2020, 3:04 PM

Change 630781 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Reenable tests disabled due to actor migration issues

https://gerrit.wikimedia.org/r/630781

gerritbot added a comment.Sep 29 2020, 3:05 PM

Change 630794 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@REL1_35] Use proper test users in Client tests

https://gerrit.wikimedia.org/r/630794

Lucas_Werkmeister_WMDE closed this task as Resolved.Sep 29 2020, 3:09 PM

I think we can close this, there aren’t any more search results for T263785 in the code.

Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 29 2020, 3:09 PM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED); removed MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 29 2020, 4:01 PM
gerritbot added a comment.Sep 30 2020, 8:32 AM

Change 630794 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@REL1_35] Use proper test users in Client tests

https://gerrit.wikimedia.org/r/630794

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits