Needs a fallback
Caused by yours truly, in rMWe834b31b2b5e: Use recordUpload3, hard deprecate recordUpload2
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Adding handling for no user passed to LocalFile::upload | mediawiki/core | master | +7 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T11968 Reduce use of global and public variables | |||
| Open | None | T159283 Deprecate non-configuration globals | |||
| Open | DannyS712 | T159299 Deprecate and remove $wgUser | |||
| Resolved | DannyS712 | T267861 [GOAL] Emit deprecation warnings reading from $wgUser | |||
| Open | DannyS712 | T243708 Mediawiki core needs uses of global $wgUser removed | |||
| Resolved | DannyS712 | T242935 Deprecate core fallbacks to $wgUser | |||
| Resolved | DannyS712 | T248813 File::recordUpload* falls back to $wgUser | |||
| Resolved | DannyS712 | T263811 LocalFile::upload without a user fails in ::recordUpload3 |
Event Timeline
Comment Actions
Change 629772 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Adding handling for no user passed to LocalFile::upload
Comment Actions
Noted it in failing tests for https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CognitiveProcessDesigner/+/629872
19:28:52 1) PDFFileResolverTest::testPDFFileResolver 19:28:52 TypeError: Argument 4 passed to LocalFile::recordUpload3() must be an instance of User, null given, called in /workspace/src/includes/filerepo/file/LocalFile.php on line 1434 19:28:52 19:28:52 /workspace/src/includes/filerepo/file/LocalFile.php:1497 19:28:52 /workspace/src/includes/filerepo/file/LocalFile.php:1434 19:28:52 /workspace/src/extensions/BlueSpiceUEModulePDF/tests/phpunit/PDFFileResolverTest.php:62 19:28:52 /workspace/src/extensions/BlueSpiceUEModulePDF/tests/phpunit/PDFFileResolverTest.php:25 19:28:52 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437 19:28:52 /workspace/src/maintenance/doMaintenance.php:107
Fix will need to be backported to 1.35
Comment Actions
Sorry, its been a long day. Please forget what I said about backporting to 1.35 - this was caused well after 1.35 was initially cut
Comment Actions
Change 629772 merged by jenkins-bot:
[mediawiki/core@master] Adding handling for no user passed to LocalFile::upload
Comment Actions
No I mean the bug was caused by code that was introduced after the initial 1.35.0-rc.0 cut, and so doesn't need to be backported to 1.35 at all (and 1.35.0 hasn't been released yet)