Page MenuHomePhabricator

Reply tool broke the list formatting
Open, Needs TriagePublic

Description

See https://fr.wikipedia.org/w/?oldid=175017673&diff=prev&diffmode=source

It's pretty obvious when the reply is being put into the middle of a numbered list.

Event Timeline

Screenshot from that fragment of the page before the edit: https://fr.wikipedia.org/w/index.php?title=Wikipédia:Pages_à_fusionner&oldid=175017212#Visualisation_de_données_et_Représentation_graphique_de_données

image.png (1×2 px, 412 KB)

This is a vote/poll and the last entry is unsigned.

I can reproduce the problem seen in that edit by clicking the reply button for the first top-level comment:

image.png (1×2 px, 456 KB)

What happens here is:

  • The last comment is unsigned, so the reply tool "doesn't see" it, and adds the new reply after the last comment it recognizes (vote 2)
  • We don't have any special handling for votes, so the reply tool adds a regular comment (indented with : / definition list)

Good spot, @Whatamidoing-WMF – how did you happen upon this diff [i]? Did someone report it? Did you find it on https://dtcheck.toolforge.org/dtcheck-2020-09-25.html ?

If the former, can you please share what Bartosz described above with this person?

  • We don't have any special handling for votes, so the reply tool adds a regular comment (indented with : / definition list)

If we did have "special handling for votes" would the tool behave in the way Sherry highlighted above considering the last comment is unsigned?


i. https://fr.wikipedia.org/w/?oldid=175017673&diff=prev&diffmode=source

  • We don't have any special handling for votes, so the reply tool adds a regular comment (indented with : / definition list)

If we did have "special handling for votes" would the tool behave in the way Sherry highlighted above considering the last comment is unsigned?

We haven't really thought about this much, so I'm just guessing as to what we would want to happen, and what we'll actually be able to implement… We might not be able to fix where in that list the new vote is added (so, it might still be in the middle of the list, before the unsigned comment), but at least it should be indented with # rather than :, so that it's a part of the numbered list.