Page MenuHomePhabricator
Create Task
Maniphest T263922

libup should set warnings to off in .eslintrc.json when using maxWarnings: 0
Closed, ResolvedPublic
Actions

Description

The Popups extension has maxWarnings: 0 in Gruntfile.js (I am not sure if that is the only wait to set it)

In this case Libup has to set also the warnings (along with errors) in .eslintrc.json to off,

Running "eslint:all" (eslint) task

/src/repo/src/preview/model.js
   9:0  warning  Invalid JSDoc tag (preference). Replace "const" JSDoc tag with "constant"  jsdoc/check-tag-names
  36:0  warning  @extends should not have a bracketed type in "typescript" mode             jsdoc/valid-types
  51:0  warning  @extends should not have a bracketed type in "typescript" mode             jsdoc/valid-types

✖ 3 problems (0 errors, 3 warnings)
  0 errors and 1 warning potentially fixable with the `--fix` option.

Warning: ESLint found too many warnings (maximum: 0) Use --force to continue.

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Check maxWarnings when disabling eslint rulesrepos/ci-tools/libup!72daimonawork/daimona/T263922master
runner: Handle repos with eslint maxWarnings: 0repos/ci-tools/libup!36taavitaavi/eslint-warningsmaster
Customize query in GitLab

Related Objects

Event Timeline

Umherirrender created this task.Sep 26 2020, 8:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2020, 8:07 PM
Jdforrester-WMF subscribed.Sep 28 2020, 3:25 PM

I think it'd be better to fix the Popups extension being odd.

Umherirrender added a comment.Sep 28 2020, 3:41 PM

NearbyPages seems also use this option

I like the idea of having no warnings, because when the warnings does not have effect, nobody looks at them

phpcs also does not allow warnings on CI for php files

Jdforrester-WMF added a comment.Sep 28 2020, 4:05 PM
In T263922#6499056, @Umherirrender wrote:

NearbyPages seems also use this option

I like the idea of having no warnings, because when the warnings does not have effect, nobody looks at them

phpcs also does not allow warnings on CI for php files

I agree, but that's a discussion for eslint-config-wikimedia.

Legoktm subscribed.Dec 29 2020, 5:55 AM

https://codesearch.wmcloud.org/search/?q=maxWarnings&i=nope&files=Gruntfile.js&repos= looks like just two repos have this option right now.

gerritbot added a comment.Dec 29 2020, 5:57 AM

Change 652278 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Popups@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/652278

gerritbot added a project: Patch-For-Review.Dec 29 2020, 5:57 AM

Change 652279 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/skins/MinervaNeue@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/652279

gerritbot added a comment.Dec 29 2020, 1:33 PM

Change 652279 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/652279

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 29 2020, 2:00 PM
gerritbot added a comment.Dec 29 2020, 2:05 PM

Change 652278 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/652278

Maintenance_bot removed a project: Patch-For-Review.Dec 29 2020, 2:10 PM
gerritbot added a comment.Dec 30 2020, 3:38 AM

Change 652466 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/tools/api-testing@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/652466

gerritbot added a project: Patch-For-Review.Dec 30 2020, 3:38 AM
gerritbot added a comment.Dec 30 2020, 7:06 PM

Change 652466 merged by jenkins-bot:
[mediawiki/tools/api-testing@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/652466

Maintenance_bot removed a project: Patch-For-Review.Dec 30 2020, 7:10 PM
gerritbot added a comment.Jan 2 2021, 4:24 PM

Change 653457 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/services/change-propagation@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/653457

gerritbot added a project: Patch-For-Review.Jan 2 2021, 4:24 PM

Change 653458 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/services/eventstreams@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/653458

gerritbot added a comment.Jan 2 2021, 4:25 PM

Change 653459 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/services/graphoid@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/653459

gerritbot added a comment.Jan 2 2021, 4:26 PM

Change 653460 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/services/mathoid@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/653460

gerritbot added a comment.Jan 2 2021, 4:26 PM

Change 653461 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/services/recommendation-api@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/653461

gerritbot added a comment.Jan 2 2021, 4:26 PM

Change 653462 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/services/restbase@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/653462

gerritbot added a comment.Jan 2 2021, 4:27 PM

Change 653463 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/services/wikifeeds@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/653463

Physikerwelt subscribed.Jan 2 2021, 5:32 PM

max warnings 0 --> error = warning this did never made sense to me:-)
As it has been merged for Popups, I'll also merge this for mathoid. On the other side, I think the discussion here might have been too sloppy not investigating in detail which warnings are severe enough to convert them to errors... However, I don't want to play the devil's advocate here.

gerritbot added a comment.Jan 2 2021, 6:51 PM

Change 653463 merged by jenkins-bot:
[mediawiki/services/wikifeeds@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/653463

gerritbot added a comment.Jan 2 2021, 6:52 PM

Change 653461 merged by jenkins-bot:
[mediawiki/services/recommendation-api@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/653461

Umherirrender mentioned this in rWSWFe504d4d5f560: build: Remove maxWarnings: 0 from eslint configuration.Jan 2 2021, 6:53 PM
gerritbot added a comment.Jan 2 2021, 6:54 PM

Change 653458 merged by jenkins-bot:
[mediawiki/services/eventstreams@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/653458

gerritbot added a comment.Jan 2 2021, 6:56 PM

Change 653457 merged by jenkins-bot:
[mediawiki/services/change-propagation@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/653457

gerritbot added a comment.Jan 2 2021, 7:00 PM

Change 653460 merged by jenkins-bot:
[mediawiki/services/mathoid@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/653460

Umherirrender mentioned this in rMSRA092b02d7e2d7: build: Remove maxWarnings: 0 from eslint configuration.Jan 2 2021, 8:01 PM
Umherirrender mentioned this in rMSCP4a326bc9c3cb: build: Remove maxWarnings: 0 from eslint configuration.Jan 2 2021, 11:22 PM
gerritbot added a comment.Jan 3 2021, 10:45 AM

Change 653783 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/skins/Mirage@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/653783

gerritbot added a comment.Jan 3 2021, 12:52 PM

Change 653783 merged by jenkins-bot:
[mediawiki/skins/Mirage@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/653783

Mainframe98 mentioned this in rSMIRaae4cac5aeb1: build: Remove maxWarnings: 0 from eslint configuration.Jan 3 2021, 12:57 PM
gerritbot added a comment.Jan 30 2021, 11:20 AM

Change 660319 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/NearbyPages@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/660319

gerritbot added a comment.Jan 30 2021, 11:24 AM

Change 653459 abandoned by Umherirrender:
[mediawiki/services/graphoid@master] build: Remove maxWarnings: 0 from eslint configuration

Reason:

https://gerrit.wikimedia.org/r/653459

gerritbot added a comment.Jan 30 2021, 11:24 AM

Change 653462 abandoned by Umherirrender:
[mediawiki/services/restbase@master] build: Remove maxWarnings: 0 from eslint configuration

Reason:

https://gerrit.wikimedia.org/r/653462

gerritbot added a comment.Feb 2 2021, 8:14 PM

Change 660319 merged by jenkins-bot:
[mediawiki/extensions/NearbyPages@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/660319

gerritbot added a comment.Feb 5 2021, 7:16 PM

Change 661985 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/skins/Vector@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/661985

gerritbot added a comment.Feb 5 2021, 9:32 PM

Change 661985 merged by jenkins-bot:
[mediawiki/skins/Vector@master] build: Remove maxWarnings: 0 from eslint configuration

https://gerrit.wikimedia.org/r/661985

ReleaseTaggerBot edited projects, added: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09); removed: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Feb 5 2021, 10:00 PM
Umherirrender removed projects: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Patch-For-Review.Feb 12 2021, 9:15 PM
Umherirrender unsubscribed.Nov 25 2021, 6:37 PM
taavi subscribed.Apr 20 2024, 1:48 PM

So this config setting has appeared in 5 repos again. I'm leaning towards just implementing support in LibUp, unless someone can figure out a way to keep it from being added back.

Novem_Linguae subscribed.Jun 24 2024, 4:27 PM
Novem_Linguae added a comment.Jun 24 2024, 4:42 PM

I'd be inclined to remove the maxWarnings: 0 from the "odd" repos. But happy to follow the group's decision.

In my mind, inline disables mean "false positive, I checked this and it's not a problem", and warns mean "todo, haven't gotten around to fixing yet".

Daimona subscribed.Apr 3 2025, 5:38 PM
Daimona added a comment.Apr 3 2025, 5:48 PM

Just came across this task while discussing other LibUp stuff in IRC. M2C: what I find odd is the existence of warnings in code checkers. If something is wrong, it should be flagged and fixed, or suppressed per-repo/file/line, and possibly fixed later. If something is not wrong, it should not be flagged. For anything in between (and that's assuming that there are going to be such semi-issues), I don't like the prospect of warnings being resurfaced every time someone touches the repo. It's confusing from a developer's perspective if your patch fails eslint and you have to scroll through 74 warnings (current number in MW core) that were there regardless of your patch, just to find the one real error hiding somewhere.

CodeReviewBot added a project: Patch-For-Review.Apr 3 2025, 11:03 PM

daimona opened https://gitlab.wikimedia.org/repos/ci-tools/libup/-/merge_requests/72

Check maxWarnings when disabling eslint rules

Daimona claimed this task.Apr 3 2025, 11:16 PM
CodeReviewBot added a comment.May 2 2025, 3:11 PM

jforrester closed https://gitlab.wikimedia.org/repos/ci-tools/libup/-/merge_requests/72

Check maxWarnings when disabling eslint rules

CodeReviewBot added a comment.May 2 2025, 3:13 PM

taavi updated https://gitlab.wikimedia.org/repos/ci-tools/libup/-/merge_requests/36

runner: Handle repos with eslint maxWarnings: 0

CodeReviewBot added a comment.May 2 2025, 3:18 PM

taavi merged https://gitlab.wikimedia.org/repos/ci-tools/libup/-/merge_requests/36

runner: Handle repos with eslint maxWarnings: 0

taavi closed this task as Resolved.May 2 2025, 3:37 PM
taavi claimed this task.
taavi added a project: Wikimedia-Hackathon-2025.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits