Page MenuHomePhabricator

Termbox on Desktop breaks Lexeme edit links
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

Go to Lexeme:L12567 on beta.

Actual Results:

  • No edit buttons and such are displayed.
  • There is a javascript error in the console.
  • The termbox module is loaded (and thus wasting bandwidth)

Expected Results:

  • Edit buttons are displayed. (and working)
  • No javascript error in the console
  • The termbox module is not loaded

This currently blocks working on T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

Event Timeline

Michael renamed this task from Termbox on Desktop breaks Lexeme edit links on beta to Termbox on Desktop breaks Lexeme edit links.Sep 28 2020, 10:41 AM

Change 630852 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Don't try to show new Termbox for Lexemes

https://gerrit.wikimedia.org/r/630852

Using the revert strategy to solve T264066: Disable termbox v2 on desktop Wikidata renders the patch here obsolete until a new attempt at T261488: trial new termbox on desktop on a test system using the same code drafted for it is made.

Change 630852 abandoned by Pablo Grass (WMDE):
[mediawiki/extensions/Wikibase@master] Don't try to show new Termbox for Lexemes

Reason:
The bug which this fixes has been reverted in Ifaec20aa47642c559254d085cb691e5affecba3c

https://gerrit.wikimedia.org/r/630852