Page MenuHomePhabricator

Disable termbox v2 on desktop Wikidata
Closed, ResolvedPublic

Description

Following the decision on T261488#6500888, we want to disable the termbox v2 on beta wikidata for the time being.

This could be achieved by either

  • reverting the code change that brought termbox v2 to the desktop view
  • disabling the relevant config on beta wikidata wiki

Acceptance criterion:

  • beta wikidata displays the old v1 termbox in the desktop mode

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptTue, Sep 29, 7:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
WMDE-leszek updated the task description. (Show Details)Tue, Sep 29, 7:04 AM

Looking at the patch which enabled termbox v2 on, i.e. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/627549 I would make a few quick observations on what potentially should be changed in code if it was chosen to not revert the change
(list not complete)

Change 631023 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[operations/mediawiki-config@master] Revert "labs: Turn on termbox v2 on wikidatawiki"

https://gerrit.wikimedia.org/r/631023

Change 631022 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] Revert "Enable Termbox v2 for desktop behind a feature flag"

https://gerrit.wikimedia.org/r/631022

Change 631023 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "labs: Turn on termbox v2 on wikidatawiki"

https://gerrit.wikimedia.org/r/631023

Mentioned in SAL (#wikimedia-operations) [2020-09-30T18:58:35Z] <hoo@deploy1001> Synchronized wmf-config/Wikibase.php: Revert "labs: Turn on termbox v2 on wikidatawiki" (T264066) (duration: 00m 58s)

Mentioned in SAL (#wikimedia-operations) [2020-09-30T19:00:23Z] <hoo@deploy1001> Synchronized wmf-config/: Revert "labs: Turn on termbox v2 on wikidatawiki" (T264066) (duration: 00m 58s)

hoo added a subscriber: hoo.Wed, Sep 30, 7:06 PM

The relevant configuration has just been removed, meaning that this is disabled on beta again (but might still be in caches).

FTR my idea was not only to disable it (https://gerrit.wikimedia.org/r/631023) but also to pull the code out (https://gerrit.wikimedia.org/r/631022) as it is dysfunctional (T263982) and should not simply be re-enabled. Instead we may want to think about how the integration is done altogether. I'm open for other approaches but that's how I meant it.

Change 631022 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Revert "Enable Termbox v2 for desktop behind a feature flag"

https://gerrit.wikimedia.org/r/631022

WMDE-leszek closed this task as Resolved.Wed, Oct 7, 3:21 PM
WMDE-leszek updated the task description. (Show Details)