Page MenuHomePhabricator

Optional messages shown by default with "showMessage" parameter and associated checkbox is empty
Closed, ResolvedPublicBUG REPORT

Description

To reproduce, navigate to Special:Translate with showMessage parameter (from wiki editor or from Special:SearchTranslations): https://translatewiki.net/w/i.php?title=Special:Translate&showMessage=listfiles_date&group=core&language=et. Then next page has optional=1 parameter set, but checkbox for optional messages is empty:

optional1.png (178×620 px, 7 KB)

If I navigate further to untranslated messages, then optional messages are shown and checkbox is still empty. Showing an optional message makes sense in case when showMessage value is an optional message, but otherwise it's inconsistent with navigating to Special:Translate without showMessage parameter that results in optional messages being hidden by default.

Event Timeline

Nikerabbit triaged this task as Medium priority.Sep 29 2020, 2:46 PM
Nikerabbit moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.
Nikerabbit added a subscriber: Nikerabbit.

I guess the fix would be quite simple, but understanding the code may take a while.

Nikerabbit changed the subtype of this task from "Task" to "Bug Report".Dec 22 2020, 9:10 AM

Change 713219 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TUX: Ensure optional message is checked based on URL options

https://gerrit.wikimedia.org/r/713219

Change 713219 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TUX: Ensure optional message is checked based on URL options

https://gerrit.wikimedia.org/r/713219

Related patch has been merged. Need to test again after deployment.