Page MenuHomePhabricator
Create Task
Maniphest T264116

Reply inserted at wrong indentation level on ja.wp (after a comment with an empty paragraph)
Closed, ResolvedPublic
Actions

Description

Reply was inserted at wrong indentation level on ja.wp (after a comment with an empty paragraph) in this edit: https://ja.wikipedia.org/w/index.php?diff=79496531

It looks like the reply tool treats the empty paragraph after the previous comment as a part of the second comment, and because of that it treats the second comment as if it was not indented.

Reported here: https://www.mediawiki.org/wiki/Topic:Vu8wzo47w82h3grl

For example, on this page/revision, in the last section:
https://ja.wikipedia.org/w/index.php?title=Wikipedia‐ノート:記事名の付け方&oldid=79273071

image.png (2×3 px, 982 KB)

  • First reply button should open the reply widget with 1 indent at the bottom – currently it opens in the middle
    image.png (2×3 px, 673 KB)
  • Second reply button should open the reply widget with 2 indents – currently it opens with 1 indent (same as previous comment)
    image.png (2×3 px, 694 KB)

Details

SubjectRepoBranchLines +/-
Ignore outdent templates at the beginning of commentsmediawiki/extensions/DiscussionToolsmaster+28 -24
Change which nodes are ignored at the beginning of comments againmediawiki/extensions/DiscussionToolsmaster+89 -21
Ignore other empty-ish things at the beginning of commentsmediawiki/extensions/DiscussionToolsmaster+169 -189
Ignore empty paragraphs at the beginning of commentsmediawiki/extensions/DiscussionToolsmaster+169 -182
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Sep 29 2020, 6:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 29 2020, 6:23 PM
matmarex claimed this task.Sep 29 2020, 8:22 PM
matmarex added a project: Editing-team (Kanban Board).
gerritbot added a comment.Sep 29 2020, 8:23 PM

Change 630937 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Ignore empty paragraphs at the beginning of comments

https://gerrit.wikimedia.org/r/630937

gerritbot added a project: Patch-For-Review.Sep 29 2020, 8:23 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Sep 29 2020, 8:23 PM
• ppelberg subscribed.Sep 29 2020, 8:59 PM
Esanders moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 30 2020, 6:10 PM
Esanders added a project: Editing QA.
Esanders subscribed.

@matmarex Please add testing steps.

Esanders moved this task from Inbox to Low Priority on the Editing QA board.Sep 30 2020, 6:10 PM
gerritbot added a comment.Sep 30 2020, 6:16 PM

Change 630937 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Ignore empty paragraphs at the beginning of comments

https://gerrit.wikimedia.org/r/630937

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED).Sep 30 2020, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 30 2020, 7:10 PM
matmarex moved this task from QA to Doing on the Editing-team (Kanban Board) board.Sep 30 2020, 9:36 PM

The second example given in https://www.mediawiki.org/wiki/Topic:Vu8wzo47w82h3grl was a horizontal like (---- in wikitext, <hr> in HTML). It's not an empty paragraph, so it also gets treated as part of the comment, and also causes invalid indentation. My patch above doesn't fix this case.

Thinking about this further, there seem to be other things that separate comments but are not part of them – such as the {{outdent}} and {{clear}} templates (and their versions on other wikis).

So I think I'd like to do this differently after all.

gerritbot added a comment.Sep 30 2020, 9:43 PM

Change 631298 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Ignore other empty-ish things at the beginning of comments

https://gerrit.wikimedia.org/r/631298

gerritbot added a project: Patch-For-Review.Sep 30 2020, 9:43 PM

Change 631299 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Ignore outdent templates at the beginning of comments

https://gerrit.wikimedia.org/r/631299

matmarex updated the task description. (Show Details)Sep 30 2020, 9:59 PM
matmarex moved this task from Doing to Code Review on the Editing-team (Kanban Board) board.
matmarex removed a project: Editing QA.
gerritbot added a comment.Oct 6 2020, 12:34 AM

Change 631298 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Ignore other empty-ish things at the beginning of comments

https://gerrit.wikimedia.org/r/631298

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Oct 6 2020, 2:27 PM
matmarex added a project: Editing QA.
• jbolorinos-ctr subscribed.Oct 7 2020, 10:29 PM
• Whatamidoing-WMF mentioned this in T251350: (Re)consider wikicode stucture generated by the Reply tool.Oct 16 2020, 6:15 PM
matmarex mentioned this in T265964: Handling for "fake headings" using ; syntax (<dt> tags).Oct 20 2020, 12:14 AM
JTannerWMF moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Nov 23 2020, 7:58 PM
JTannerWMF removed a project: Editing QA.
JTannerWMF added subscribers: Ryasmeen, JTannerWMF.

@matmarex please add testing instructions then move it back to @Ryasmeen column

gerritbot added a comment.Dec 14 2020, 8:37 PM

Change 649443 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Change which nodes are ignored at the beginning of comments again

https://gerrit.wikimedia.org/r/649443

matmarex moved this task from Blocked / Needs More Work to Code Review on the Editing-team (Kanban Board) board.Dec 14 2020, 8:38 PM

It seems I'm still not sure myself how exactly this should work…

gerritbot added a comment.Jan 4 2021, 9:47 PM

Change 649443 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Change which nodes are ignored at the beginning of comments again

https://gerrit.wikimedia.org/r/649443

gerritbot added a comment.Jan 4 2021, 9:48 PM

Change 631299 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Ignore outdent templates at the beginning of comments

https://gerrit.wikimedia.org/r/631299

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 2021-01-05); removed MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED).Jan 4 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 4 2021, 10:10 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jan 5 2021, 7:56 PM

Test pages:

Replying to any comment should behave exactly the same on both pages. Previously, the various separators (present on the first page) would cause the reply tool to insert replies in the wrong places or on the wrong indentation levels. Now they should be completely ignored.

matmarex added a project: Editing QA.Jan 5 2021, 7:56 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jan 13 2021, 11:53 PM

Checked the indentation levels of different comments that includes different kinds of separators on the original page mentioned in the task description and also checked the test pages provided. Comments are now getting indented correctly.

Ryasmeen removed a project: Editing QA.Jan 13 2021, 11:53 PM
• ppelberg closed this task as Resolved.Jan 16 2021, 3:24 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 16 2021, 3:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL