Page MenuHomePhabricator

[Regression pre-1.36wmf.12] "Change Reference Type" button is showing up on Table Properties dialog
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Open VE
  2. Insert a table
  3. Go to Table>Properties

Observed Result:
A button "Change Reference Type" is showing up, which doesn't do anything if you click on it.

Screenshot/Screen capture:

Browser: Chrome

Wiki: English

Editor: VE

Page: https://en.wikipedia.beta.wmflabs.org/wiki/User:RYasmeen_(WMF)/sandbox
Environment: Beta cluster

Event Timeline

Ryasmeen created this task.Tue, Sep 29, 9:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Sep 29, 9:22 PM
Ryasmeen renamed this task from [Regression pre-1.36wmf.12] "Change Reference Type" button showing up on Table Properties dialog to [Regression pre-1.36wmf.12] "Change Reference Type" button is showing up on Table Properties dialog.Tue, Sep 29, 9:22 PM
Ryasmeen triaged this task as Unbreak Now! priority.
matmarex claimed this task.Tue, Sep 29, 9:27 PM
matmarex added a subscriber: matmarex.

That button was added in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Citoid/+/483337, but it shouldn't appear in this dialog, obviously.

The wmf.11 branch was already cut without the faulty patch, so we don't need to backport the fix, just merge it before next week's branch cut.

Change 630952 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Citoid@master] Fix "Change reference type" button appearing in unrelated dialogs

https://gerrit.wikimedia.org/r/630952

barakat1 renamed this task from [Regression pre-1.36wmf.12] "Change Reference Type" button is showing up on Table Properties dialog to [الانحدار قبل 1.36wmf.12] يظهر الزر "تغيير نوع المرجع" في مربع الحوار خصائص الجدول.Tue, Sep 29, 9:35 PM
matmarex renamed this task from [الانحدار قبل 1.36wmf.12] يظهر الزر "تغيير نوع المرجع" في مربع الحوار خصائص الجدول to [Regression pre-1.36wmf.12] "Change Reference Type" button is showing up on Table Properties dialog.Tue, Sep 29, 9:48 PM

That button was added in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Citoid/+/483337, but it shouldn't appear in this dialog, obviously.

That's why I waited until Tuesday :)

Esanders moved this task from To Triage to Triaged on the VisualEditor board.Wed, Sep 30, 5:53 PM
Esanders moved this task from Code Review to QA on the Editing-team (FY2020-21 Kanban Board) board.
Esanders added a project: Editing QA.
Esanders moved this task from Inbox to High Priority on the Editing QA board.

Should be easy to test :)

Change 630952 merged by jenkins-bot:
[mediawiki/extensions/Citoid@master] Fix "Change reference type" button appearing in unrelated dialogs

https://gerrit.wikimedia.org/r/630952

Should be easy to test :)

yes, fixed now :)

Ryasmeen edited projects, added Verified; removed Editing QA.Wed, Sep 30, 7:12 PM
ppelberg closed this task as Resolved.Thu, Oct 1, 12:55 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptThu, Oct 1, 12:55 AM